Re: RFR: 8392561: [GCC static analyzer] potential dereference of NULL pointer xsdo in Java_sun_java2d_x11_XSurfaceData_isDrawableValid

[Phil Race]

On Fri, 16 Oct 2026 10:38:16 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:

> The gcc static analyzer reports this issue :
> 
> `src/java.desktop/unix/native/common/java2d/x11/X11SurfaceData.c:181:13: 
> warning: dereference of NULL 'xsdo' [CWE-476] [-Wanalyzer-null-dereference]`
> 
> Seems we should better NULL-check the result of
> `    X11SDOps *xsdo = X11SurfaceData_GetOps(env, this);`
> because the function potentially returns NULL.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Seems reasonable

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/33410#pullrequestreview-5553758640