On Thu, 12 Nov 2026 03:49:11 GMT, Phil Race <[email protected]> wrote:

>> Specifying the behaviour of BufferedImage constructors for invalid 
>> dimensions is long overdue.
>> 
>> The behaviour for image types and sizes <= 0 is unchanged by this PR.
>> Also in many cases the behaviour for sizes that are too large is also 
>> unchanged.
>> In some cases, the behaviour is changed from "accidental" 
>> NegativeArraySizeException to a consistent IllegalArgumentException.
>> 
>> In no case is anything changed that would affect the possibility to 
>> construct a BufferedImage.
>> 
>> A test is provided to ensure the behaviour.
>> 
>> A CSR is provided too : https://bugs.openjdk.org/browse/JDK-8369155
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Phil Race has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   4617681

test/jdk/java/awt/image/BufferedImage/CreateBufferedImageTest.java line 44:

> 42: 
> 43:         test(TYPE_CUSTOM, 10); // TYPE_CUSTOM is not a valid parameter.
> 44:         test(-1, 10);

Probably we should validate against 0 and -ve dimensions more like

        { 10, -1 },
        { 0, 0 },
        { -1, -1 },
        { Integer.MIN_VALUE, 10 },
        { 10, Integer.MIN_VALUE }

as `BufferedImage.checkDimentions` has added the 0 and -ve check
{-1, -1} case might be useful because multiplying two negative dimensions 
produces a positive value which will check that positivity is validated 
separately..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27640#discussion_r4546821634

Reply via email to