On Thu, 19 Nov 2026 22:27:13 GMT, Phil Race <[email protected]> wrote:

>> The native code on macOS which initializes cached JNI refs is not thread 
>> safe.
>> The fix is to use the macOS dispatch_once mechanism as a lock.
>> The fix is essentially all in JNIUtilities.h. There's some refactoring of 
>> the macros in there to make things a bit cleaner
>> and DECLARE_*_ONLY macros are added which the non-local clients now use to 
>> declare variables.
>> 
>> The problem can be demonstrated with multi-threaded initialisation, and 
>> using -Xcheck:jni
>> A case which reproduces "fairly often" has been added as a test.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Phil Race has updated the pull request with a new target base due to a merge 
> or a rebase. The pull request now contains five commits:
> 
>  - Merge
>  - 8393035
>  - 8393035
>  - 8393035
>  - 8385973

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/33481#pullrequestreview-5987565430

Reply via email to