Hey Sam, I'm glad you were able to refactor the code, I had a fear that it was too unreadable.
There were several other bugs in that version that you should know of: - First version didn't use StringBuilder, which accounted for very slow times. - Semicolons aren't handled correctly in code and can be mistaken for comments. - Vector styles overflow into other elements. I posted a new version that fixes all of these. I feel it's easier to read and more flexible. It has the added feature of underlining any functions you call that you have defined previously in the code. I'm just beefing up this script until I see a glimmer that draws my attention to a different project. ~ Kai On Jun 30, 12:17 am, Sam Griffith <stayp...@mac.com> wrote: > Thanks for doing this. > > I think I fixed one bug so wanted to mention it. In your html-post- > format function, you have a string that creates the first <div>. It > has a explicit style set to have a font-family: courier new and a font- > size of 14px. I took those styles out so that the style sheet > controlled that correctly. > > I also made it so that when the standalone? variable wasn't set to > true that the styles would be embedded into the html that is output. > This allows for cases where you don't have a style.css or where you > want the html to have it's own just for the one file. I'm sure you > know all that though but it's been fun playing around with this code > and adding these little features. > > - Sam > > On Jun 26, 9:27 pm, Kai <poki...@gmail.com> wrote: > > > I fixed a bug that messed up spacing (ampersands weren't converted in > > html-pre-format), so be sure to use the latest version. > > > Of course, feel free to use it on your webpage! > > > ~ Kai > > > On Jun 26, 9:09 pm, CuppoJava <patrickli_2...@hotmail.com> wrote: > > > > Hi Kai, > > > That is really cool! Do you mind if I use it on my webpage? > > > > As for coding style, I must say that yours is very clear. It was very > > > easy to read through the whole thing. > > > > -Patrick --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en -~----------~----~----~----~------~----~------~--~---
