Agreed with everything Sean said, except I wanted to point out that making a unit test for functions that create GUI windows might be a little bit out of the beaten path of the existing unit tests. There may be a way to create a unit test that calls inspect-table with arguments that make it throw an exception with the current version, and doesn't with Jim's proposed new version, but not sure about that.
Also, Jim, don't expect a quick turnaround on changes to Clojure core. They can take a while to get in. If you really like using your improved version of inspect-table and want to use it, put it in your own local library and use it (or make your own local modified version of Clojure for your own use). Andy On Jun 18, 2012, at 12:07 PM, Sean Corfield wrote: > JIRA - http://dev.clojure.org/jira/browse/CLJ (since this is a "core" > Clojure namespace). > > If you have a CA on file, you can create a patch and attach it to the > ticket. If you don't have a CA on file, you can outline what you think > needs to be done (as you have below) and someone with a CA on file can > create a patch based on your suggestions, along with additional unit > tests to show that the behavior would be correct (should be easy to > create a test that fails now but would pass after this change?). > > Sean > > On Mon, Jun 18, 2012 at 11:22 AM, Jim - FooBar(); <jimpil1...@gmail.com> > wrote: >> the very first let binding in clojure.inspector/old-table-model should be: >> >> row1 (some #(when-not (nil? %) %) data) >> >> instead of >> >> row1 (first data) >> >> simply because it will fail if the (first data) returns nil... >> >> where do we submit minor improvements like this? -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en
