Thanks for the comment. The current behaviour is sensible for the code 
branch where the second argument is the same length or shorter than the 
first (see my first post). It is the other branch that does not do what you 
would expect. My real issue though is how the behaviour changes 
dramatically once we hit this branch (for non set args).

The original author of the 
patch<https://github.com/clojure/clojure/commit/60e805dc7bd42b7b26fc8c8925bf71079729e0e6>which
 produced this behaviour noted 
this shortcoming himself <http://dev.clojure.org/jira/browse/CLJ-67>, and 
only refrained from implementing the check due to being unsure about the 
performance penalty.

I think that people who are currently relying on this function working for 
non set arguments are playing a risky game (which, like me, they're 
probably not aware of) due to this sudden change in behaviour. I would 
argue that existing users would be better served by having an error thrown 
rather than having unexpected data generated which is hard to track down.

On Sunday, September 29, 2013 7:05:17 PM UTC-4, stuart....@gmail.com wrote:
>
> I think the bar for such an enhancement is fairly high, and the value 
> delivered fairly low.  It isn't so much the impact of assessing this single 
> change, as the impact of managing the universe of such changes.
>
> Regards,
> Stu
>

-- 
-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to