"but it won't give useful information if you don't construct the op inline."
The interesting question here is what constitutes useful information! The trade-off is breaking an existing public API. If Shalaka's primary goal is prettier errors in test failures, I'd settle for the fn body itself as the error message and that could be achieved without breaking the API. On Thu, May 28, 2015 at 11:04 PM, Herwig Hochleitner <hhochleit...@gmail.com > wrote: > 2015-05-28 19:22 GMT+02:00 Mohit Thatte <mohit.tha...@gmail.com>: > >> Changing wait-until to a macro seems like the simplest way to tackle >> this. It gives you access to pred at compile time, does not force the >> caller to add meta-data to pred, and you can construct the error message as >> you like. >> > > I was actually thinking about constructing the fns you pass to > `wait-until` with a macro (defop, ..). > > The challenge with your approach 1 would be to change all existing calls >> to wait-until and add meta to them. >> > > Making `wait-until` a macro may provide a way around that, but it won't > give useful information if you don't construct the op inline. > > -- > You received this message because you are subscribed to the Google > Groups "Clojure" group. > To post to this group, send email to clojure@googlegroups.com > Note that posts from new members are moderated - please be patient with > your first post. > To unsubscribe from this group, send email to > clojure+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/clojure?hl=en > --- > You received this message because you are subscribed to the Google Groups > "Clojure" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to clojure+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -Mohit Thatte -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en --- You received this message because you are subscribed to the Google Groups "Clojure" group. To unsubscribe from this group and stop receiving emails from it, send an email to clojure+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
