When it's just a matter of correcting typos, I tend to fork the project, do the edit directly in the github gui, commit, and add a pull request, which would correspond to steps 1,5,6,8 below.
Erik. -- i farta > Den 25. des. 2015 kl. 08.36 skrev Mimmo Cosenza <mimmo.cose...@gmail.com>: > > Hi Erlis, > the best way to correct typos is by using the pull request mechanics of github > > 1. fork the project from github User Interace > 2. clone locally the forked project > > git clone https://github.com/yourname/modern-cljs.git > > cd modern-cljs > 3. add the upstream to remote > > git remote add upstream https://github.com/magomimmo/modern-cljs.git > 4. be sure of being in the master branch > > git checkout master > 5. correct the typos: the tutorias of the second edition are located under > the doc/second-edition directory > 6. commit the correction > > git commit -am “typos” > 7. push the commit to origin (your fork) > > git push origin master > 8. Pull request from github User Interface > > After a while this process become a second nature :-) > > HIH > mimmo > >> On 25 Dec 2015, at 03:45, Erlis Vidal <er...@erlisvidal.com> wrote: >> >> I'm using Virtual Box with XUbuntu, and everything runs smooth there. I've >> also installed boot on Windows but I haven't work there yet. >> >> Great work Mimmo, by the way, while working on the tutorial I've found 2 >> typos, where can I send you the corrections? >> >> Thanks for creating this! >> >> Erlis >> >>> On Thu, Dec 24, 2015 at 7:08 AM, Mimmo Cosenza <mimmo.cose...@gmail.com> >>> wrote: >>> I wrote a warning note in the README.MD of the series, by suggesting to use >>> virtualbox or docker to be able to follow the tutorial. >>> I really do not have any MS Windows skill to be able to help anyone on >>> those OSs. >>> >>> My best >>> >>> mimmo >>> >>>> On Dec 24, 2015, at 9:13 AM, 'Sven Richter' via ClojureScript >>>> <clojurescr...@googlegroups.com> wrote: >>>> >>>> Also I just added a new doc issue: >>>> https://github.com/boot-clj/boot/issues/368 >>>> >>>> Am Donnerstag, 24. Dezember 2015 09:12:16 UTC+1 schrieb Sven Richter: >>>>> >>>>> Hi Mimmo, >>>>> >>>>> No problem, I was afraid that you are not aware of it. I guess a lot of >>>>> people are not. In fact there have been windows issues made aware to the >>>>> developers of boot for a long time: >>>>> https://github.com/boot-clj/boot/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+windows >>>>> >>>>> If they work on them or not is their decision. Like I said, I don't care >>>>> about OS either, in fact I have been a linux proponent since the mid >>>>> 90-ies, but not everyone is and we should be aware of that. >>>>> >>>>> Of course you also have to decide for yourself how you handle that, now >>>>> you know the consequences. >>>>> >>>>> Have a merry christmas too, >>>>> Sven >>>>> >>>>> Am Donnerstag, 24. Dezember 2015 09:02:30 UTC+1 schrieb Magomimmo: >>>>>> >>>>>> Hi Sven, >>>>>> it was not my intention to exclude anyone. It's just that I never used >>>>>> windows in my life (if I exclude a short period in which I used >>>>>> VisualJ++ because was amazingly faster than the Sun counterpart Java IDE >>>>>> (around 1997). >>>>>> >>>>>> I'll appreciate any contribution from anyone skilled in that OS, because >>>>>> I don't even have a windows OS to test boot and I did not even known >>>>>> that boot does not run on windows, considering that in the readme you >>>>>> can read about it. >>>>>> >>>>>> https://github.com/boot-clj/boot#windows >>>>>> >>>>>> So, sorry about that. This is something the boot maintainers should work >>>>>> on. >>>>>> >>>>>> that said, I think that even windows users could use boot via a virtual >>>>>> machine or a Linux containers (e.g. docker). >>>>>> >>>>>> To me the OS is just a commodity, as it is the JVM too. I just don't >>>>>> care about them until they create me a problem. >>>>>> >>>>>> Have great holidays! >>>>>> >>>>>> mimmo >>>>>> >>>>>> On Thursday, December 24, 2015 at 8:33:50 AM UTC+1, Sven Richter wrote: >>>>>> > Hi, >>>>>> > >>>>>> > While I appreciate everyones work and also like boots approach to >>>>>> > building clojure libs I want to remind you that boot still does not >>>>>> > work on windows. >>>>>> > Therefore you are excluding every windows user from your tutorial. >>>>>> > >>>>>> > I am not sure if I was into clojure as I am today if some of the >>>>>> > tutorials just would not have worked when I started learning it. >>>>>> > >>>>>> > I don't know how many people here are using windows vs linux, also I >>>>>> > don't want to start an OS war, but I know for sure that there is a lot >>>>>> > of business developers that are using windows only and by moving more >>>>>> > and more to boot we are closing a gate here as long as boot does not >>>>>> > support windows. >>>>>> > >>>>>> > Best Regards, >>>>>> > Sven >>>>>> > >>>>>> > Am Sonntag, 20. Dezember 2015 18:47:14 UTC+1 schrieb Magomimmo: >>>>>> > Hi all, >>>>>> > >>>>>> > I just published the 17th tutorial- REPLing with Enlive - of the >>>>>> > modern-cljs series. >>>>>> > It has been realy easy to port the first edition of the tutorial, >>>>>> > which was based on leiningen/cljsbuild, to boot build tool (release >>>>>> > 4.2.3 at the moment). I'm really impressed by the signal/noise ratio >>>>>> > of boot vs. leiningen/cljsbuild and it has been really easy as well to >>>>>> > create a TDD environment which includes live coding with the REPL >>>>>> > (both a CLJ REPL and a CLJS REPL). There is still room for improvement >>>>>> > to better support a tight TDD worflow (i.e. dinamically filter test >>>>>> > nameaspaces in the test and the test-cljs tasks). I'm pretty sure the >>>>>> > boot community will quickly fix that issue. >>>>>> > https://github.com/magomimmo/modern-cljs/blob/master/doc/second-edition/tutorial-17.md >>>>>> > >>>>>> > HIH >>>>>> > mimmo >>>> >>>> >>>> -- >>>> Note that posts from new members are moderated - please be patient with >>>> your first post. >>>> --- >>>> You received this message because you are subscribed to the Google Groups >>>> "ClojureScript" group. >>>> To unsubscribe from this group and stop receiving emails from it, send an >>>> email to clojurescript+unsubscr...@googlegroups.com. >>>> To post to this group, send email to clojurescr...@googlegroups.com. >>>> Visit this group at https://groups.google.com/group/clojurescript. >>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Clojure" group. >>> To post to this group, send email to clojure@googlegroups.com >>> Note that posts from new members are moderated - please be patient with >>> your first post. >>> To unsubscribe from this group, send email to >>> clojure+unsubscr...@googlegroups.com >>> For more options, visit this group at >>> http://groups.google.com/group/clojure?hl=en >>> --- >>> You received this message because you are subscribed to the Google Groups >>> "Clojure" group. >>> To unsubscribe from this group and stop receiving emails from it, send an >>> email to clojure+unsubscr...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >> >> >> -- >> You received this message because you are subscribed to the Google >> Groups "Clojure" group. >> To post to this group, send email to clojure@googlegroups.com >> Note that posts from new members are moderated - please be patient with your >> first post. >> To unsubscribe from this group, send email to >> clojure+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/clojure?hl=en >> --- >> You received this message because you are subscribed to the Google Groups >> "Clojure" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to clojure+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google > Groups "Clojure" group. > To post to this group, send email to clojure@googlegroups.com > Note that posts from new members are moderated - please be patient with your > first post. > To unsubscribe from this group, send email to > clojure+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/clojure?hl=en > --- > You received this message because you are subscribed to the Google Groups > "Clojure" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to clojure+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en --- You received this message because you are subscribed to the Google Groups "Clojure" group. To unsubscribe from this group and stop receiving emails from it, send an email to clojure+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
