Looks OK to me. JIRA Ticket + patch please, thanks!

David


On Thu, Jan 2, 2014 at 8:38 PM, Ivan Willig <iwil...@gmail.com> wrote:

> Hi list,
>
> While I was messing around with ClojureScript and nodejs this week, I
> noticed that the Google Closure compiler complains when JavaScript
> reserved words are used.  Newer versions of JavaScript engines allow
> reserved words (like "static", "class") to be used as object
> properties. The Closure Compiler knows this and does not complain when
> you set the language_in option to the correct version of JavaScript.
>
> I have opened a PR that allows you to set the language_in and
> language_out options. I have never contributed to clojurescript, so
> please tell me what I did wrong. :).
>
> I know submitting a patch might be easier, but I figure a github PR is
> better for feedback.
>
> https://github.com/clojure/clojurescript/pull/31/files
>
> Thank you
>
> Ivan Willig
>
> --
> Note that posts from new members are moderated - please be patient with
> your first post.
> ---
> You received this message because you are subscribed to the Google Groups
> "ClojureScript" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to clojurescript+unsubscr...@googlegroups.com.
> To post to this group, send email to clojurescript@googlegroups.com.
> Visit this group at http://groups.google.com/group/clojurescript.
>

-- 
Note that posts from new members are moderated - please be patient with your 
first post.
--- 
You received this message because you are subscribed to the Google Groups 
"ClojureScript" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojurescript+unsubscr...@googlegroups.com.
To post to this group, send email to clojurescript@googlegroups.com.
Visit this group at http://groups.google.com/group/clojurescript.

Reply via email to