Looks good to me, the code clearly expresses your intent.   Just a couple minor 
formatting suggestions:

Line 9 - put each let binding on a new line, it's more readable

Also, move the comments to doc strings.  This was a habit it took me awhile to 
get used to as well, but I think it is worthwhile.  Besides the obvious benefit 
of making it work with the 'doc' function, it also makes the code flow better 
when reading it, and you can reserve comments for delineating major sections of 
a larger source file.

I also think comments within a function are suspect - in general, if a block of 
code is complicated enough to warrant a comment, it probably should be pulled 
out into its own function.  Maybe this one is more personal preference than 
idiomatic, so YMMV.

-- 
Note that posts from new members are moderated - please be patient with your 
first post.
--- 
You received this message because you are subscribed to the Google Groups 
"ClojureScript" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/clojurescript.

Reply via email to