Hi David, I totally agree that the om tutorial is not the minimal case, I've just used it to demonstrate the problemS we encountered in our (soon to be production) code without bringing in a much bigger code base that also depends on API call to our backend systems and hence a bit impractical to post. I can post it without those dependencies, but the main problem is the same as in the tutorial: errors happening when clicking on an input field, and errors similar to the ones happening when calling add contact in the tutorial. onChange event on input fields is tricky in IE8 and IE9, but should be taken care of by React (see: http://benalpert.com/2013/06/18/a-near-perfect-oninput-shim-for-ie-8-and-9.html), so I'm not sure why it does work with plain react but not with Om. Looking at Om's source come (https://github.com/swannodette/om/blob/master/src/om/dom.cljs), I see that you wrap form elements (input, textarea and option), and make them React components, providing a default onChange handler in case the user didn't provide one, but that's the only difference from using React.DOM.input directly. If you want I can even post a bare bones example with the form-field and click event on it throwing errors in IE8 with Om and have a similar example with only React that does not show that errors.
Thanks in advance Tal On Thursday, June 26, 2014 2:11:00 PM UTC-4, David Nolen wrote: > The Om tutorial should not be used as a minimal case. If people want > > to edit the tutorial so that it works for more browsers be my guest. I > > would like to see minimal cases that reflects something occurring in > > actual production code that demonstrates that there are serious issues > > with IE8. It's likely that (enable-console-print!) will be problematic > > in IE8. If it is you'll want to supply your own *print-fn*. > > > > David > > > > On Thu, Jun 26, 2014 at 5:42 AM, tal giat wrote: > > > On Monday, June 23, 2014 12:28:07 PM UTC-4, David Nolen wrote: > > >> Sorry been a bit busy. I cannot replicate your issue: > > >> > > >> > > >> > > >> I ran the following: > > >> > > >> > > >> > > >> lein cljsbuild once om-tut > > >> > > >> python -m SimpleHTTPServer > > >> > > >> > > >> > > >> I navigated to http://10.0.2.2:8000/index.html in IE8 running under > > >> > > >> Windows 7 under VirtualBox - it works. > > >> > > >> > > >> > > >> Do you have more details? > > >> > > >> > > >> > > >> David > > >> > > >> > > >> > > >> On Mon, Jun 23, 2014 at 12:11 PM, tal giat wrote: > > >> > > >> > On Wednesday, June 11, 2014 7:36:28 PM UTC-4, David Nolen wrote: > > >> > > >> >> Thanks for bringing this up. I will try to take a look at this > > >> > > >> >> > > >> > > >> >> tomorrow, Friday at the latest. > > >> > > >> >> > > >> > > >> >> > > >> > > >> >> > > >> > > >> >> David > > >> > > >> >> > > >> > > >> >> > > >> > > >> >> > > >> > > >> >> On Wed, Jun 11, 2014 at 7:23 PM, tal giat wrote: > > >> > > >> >> > > >> > > >> >> > Can't seem to get those working with IE8/IE9. > > >> > > >> >> > > >> > > >> >> > > > >> > > >> >> > > >> > > >> >> > I've created a project on github to demonstrate that: > >> >> > https://github.com/talgiat/om-tutorial which is basically the very > >> >> > first example (Hello world) in the om tutorial. > > >> > > >> >> > > >> > > >> >> > This version displays Hello world! in a web-page. > > >> > > >> >> > > >> > > >> >> > It doesn't work in IE8 or IE9 even after adding the react IE shims > >> >> > (http://facebook.github.io/react/docs/working-with-the-browser.html#browser-support-and-polyfills) > > >> > > >> >> > > >> > > >> >> > React itself DOES work on IE8 with those shims, as we have a > >> >> > production system that we wrote that uses it and works fine on all IE > >> >> > versions 8 and up. > > >> > > >> >> > > >> > > >> >> > IE8 complains about goog.string.hashCode not existing. With more > >> >> > complex examples I've seen it complain about other methods in > >> >> > goog.string like contains. > > >> > > >> >> > > >> > > >> >> > > > >> > > >> >> > > >> > > >> >> > Not sure what causes the problem, but wanted to know did anyone > >> >> > encountered it before and what are possible solutions. > > >> > > >> >> > > >> > > >> >> > > > >> > > >> >> > > >> > > >> >> > We just started using clojurescript and Om for a major b2b web-based > >> >> > product we have here, unfortunately we must support IE8 and up since > >> >> > we have major customers using it. I'd really hate to revert back to > >> >> > JavaScript. > > >> > > >> >> > > >> > > >> >> > > > >> > > >> >> > > >> > > >> >> > Thanks > > >> > > >> >> > > >> > > >> >> > > > >> > > >> >> > > >> > > >> >> > -- > > >> > > >> >> > > >> > > >> >> > Note that posts from new members are moderated - please be patient > >> >> > with your first post. > > >> > > >> >> > > >> > > >> >> > --- > > >> > > >> >> > > >> > > >> >> > You received this message because you are subscribed to the Google > >> >> > Groups "ClojureScript" group. > > >> > > >> >> > > >> > > >> >> > To unsubscribe from this group and stop receiving emails from it, > >> >> > send an email to clojurescript+unsubscr...@googlegroups.com. > > >> > > >> >> > > >> > > >> >> > To post to this group, send email to clojurescript@googlegroups.com. > > >> > > >> >> > > >> > > >> >> > Visit this group at http://groups.google.com/group/clojurescript. > > >> > > >> > > > >> > > >> > Hi David, any updates on this ? > > >> > > >> > > > >> > > >> > Thanks > > >> > > >> > > > >> > > >> > Tal > > >> > > >> > > > >> > > >> > -- > > >> > > >> > Note that posts from new members are moderated - please be patient with > >> > your first post. > > >> > > >> > --- > > >> > > >> > You received this message because you are subscribed to the Google > >> > Groups "ClojureScript" group. > > >> > > >> > To unsubscribe from this group and stop receiving emails from it, send > >> > an email to clojurescript+unsubscr...@googlegroups.com. > > >> > > >> > To post to this group, send email to clojurescript@googlegroups.com. > > >> > > >> > Visit this group at http://groups.google.com/group/clojurescript. > > > > > > Thanks for testing David. I've re-tested and it worked fine on IE8 on > > windows 7 but not on IE8 emulation mode on IE11 (but that does not matter). > > > > > > I've actually re-tested the first example of the tutorial on the same box > > and got errors when trying to add contact. Even just clicking on the field > > produces errors, as well as trying to add a contact. Note, that deleting > > contact works fine. > > > I've posted all with instructions and a screenshot of the error on > > Windows7/IE8 (not a VM but a regular installation on Dell laptop). > > > Repo and instruction are here: https://github.com/talgiat/om-tut > > > > > > Thanks > > > > > > Tal > > > > > > -- > > > Note that posts from new members are moderated - please be patient with > > your first post. > > > --- > > > You received this message because you are subscribed to the Google Groups > > "ClojureScript" group. > > > To unsubscribe from this group and stop receiving emails from it, send an > > email to clojurescript+unsubscr...@googlegroups.com. > > > To post to this group, send email to clojurescript@googlegroups.com. > > > Visit this group at http://groups.google.com/group/clojurescript. -- Note that posts from new members are moderated - please be patient with your first post. --- You received this message because you are subscribed to the Google Groups "ClojureScript" group. To unsubscribe from this group and stop receiving emails from it, send an email to clojurescript+unsubscr...@googlegroups.com. To post to this group, send email to clojurescript@googlegroups.com. Visit this group at http://groups.google.com/group/clojurescript.
