Ben,
I'm wrt ds_cfg, you're right. It would appear that this is fine. so if you
have cloud-config installed on the system with content like:
datasource:
SmartOS:
no_base64_decode: true
then you can get that value in __init__ after calling super with
'self.ds_cfg.get("no_base64_decode")'. However, you're currently just getting
it from sys_cfg, which would be top level cloud-config (not under datasource at
all).
Some other things we talked about, and I had thought you were planning on
addressing:
* use of the word 'lossy' is inconsistent. I might just remove all uses of it
and instead just mention that base64 encoding the data will be completely safe,
but data that includes a '\n.\n' will be otherwise be interpreted wrong.
* "In order to provide a lossy format" (loss*less*, not lossy). but "data
safe" might be better.
* I've just now noticd that the example in
doc/examples/cloud-config-datasources.txt is wrong, and includes 'serial
device' (not 'serial_device' , ie no underbar).
--
https://code.launchpad.net/~utlemming/cloud-init/smartos_base64/+merge/177716
Your team cloud init development team is requested to review the proposed merge
of lp:~utlemming/cloud-init/smartos_base64 into lp:cloud-init.
_______________________________________________
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help : https://help.launchpad.net/ListHelp
