Review: Needs Fixing
I'm gonna need some help here
Diff comments:
> diff --git a/cloudinit/net/tests/test_dhcp.py
> b/cloudinit/net/tests/test_dhcp.py
> index db25b6f..ad0a9fb 100644
> --- a/cloudinit/net/tests/test_dhcp.py
> +++ b/cloudinit/net/tests/test_dhcp.py
> @@ -321,3 +321,10 @@ class TestSystemdParseLeases(CiTestCase):
> '9': self.lxd_lease})
> self.assertEqual({'1': self.azure_parsed, '9': self.lxd_parsed},
> networkd_load_leases(self.lease_d))
> +
> +
> +class TestNoNetworkSetup(CiTestCase):
> +
> + def skip_with_connectivty_url(self):
honestly: no idea how to test this
None of the tests in this file look even close to the ones in test_init.py
> + """Test setup skip when connectivity_url can be reached"""
> + pass
--
https://code.launchpad.net/~i.galic/cloud-init/+git/cloud-init/+merge/358876
Your team cloud-init commiters is requested to review the proposed merge of
~i.galic/cloud-init:feax/ephemeral_connectivity into cloud-init:master.
_______________________________________________
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help : https://help.launchpad.net/ListHelp
