This looks good to me now, thanks. Steve, one style comment in-line though.
I'll get someone to point the c-i bot at this too. Diff comments: > diff --git a/cloudinit/sources/DataSourceEc2.py > b/cloudinit/sources/DataSourceEc2.py > index 1010745..1ca4488 100644 > --- a/cloudinit/sources/DataSourceEc2.py > +++ b/cloudinit/sources/DataSourceEc2.py > @@ -33,6 +33,7 @@ class CloudNames(object): > ALIYUN = "aliyun" > AWS = "aws" > BRIGHTBOX = "brightbox" > + ZStack = "zstack" the variable needs to be all caps. the value is correct. > # UNKNOWN indicates no positive id. If strict_id is 'warn' or 'false', > # then an attempt at the Ec2 Metadata service will be made. > UNKNOWN = "unknown" -- https://code.launchpad.net/~ruansx/cloud-init/+git/cloud-init/+merge/372445 Your team cloud-init Commiters is requested to review the proposed merge of ~ruansx/cloud-init:add-zstack-datasource into cloud-init:master. _______________________________________________ Mailing list: https://launchpad.net/~cloud-init-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
