Maybe, but I don't think we really wanted to always append a header to the 
file, and we certainly wanted to avoid writing the file if we didn't have a 
config.  Lastly the side-effect of modifying resolvconf without dns settings 
disabled system auto-generation.

We do need to be careful w.r.t detecting whether netconfig is present or not.  
I think that we could replace updating resolvconf directly if netconfig is 
present.   This renderer is shared by a range of SuSE and RHEL releases which 
may or maynot have netconfig (or something equivalent).

I'd like Robert to comment on whether we want to move to netconfig or not.  
That can be done incrementally (land this fix of not touching resolv.conf at 
all if we don't have settings) and then separately replacing writing 
resolv.conf directly with using netconfig if present.


-- 
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/372727
Your team cloud-init Commiters is requested to review the proposed merge of 
~raharper/cloud-init:fix/sysconfig-skip-resolvconf-no-dns-config into 
cloud-init:master.

_______________________________________________
Mailing list: https://launchpad.net/~cloud-init-dev
Post to     : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to