dustymabe added a new comment to an issue you are following: `` > Example of multi-line description is here: > https://hhorak.fedorapeople.org/httpd-docker/Dockerfile > I think it works still quite well and looks better in the Dockerfile than one > long line IMO.
Yes, but what you are doing is breaking up what will be a single line into multiple lines when you define it. That is perfectly fine IMHO. What I didn't want was newlines in the actual value. I think what you have is fine, assuming I understand everything correctly. You also have SUMMARY and DESCRIPTION. I think what we were proposing for DESCRIPTION actually matches more closely with what you have for SUMMARY. I know this is taken from rpm world, I just wonder if we need both. > Anyway, the New requirements seem fine to me, with those thoughts: > ad 3: I expect that OSBS in Fedora uses atomic-reactor that is able to > convert and add the README.md from dist-git to help.1 and add the COPY > command into the Dockerfile. Why not use this feature? It would limit the > maintainer's responsibility to maintain README.md only. I don't think we knew about this feature. Do you have a link to more details? > ad 6: There is an 'url' label in the generic guidelines if anybody wants to > point users to some URL: > https://github.com/projectatomic/ContainerApplicationGenericLabels/ interesting. I like it. `url` could be useful and I really like `vcs-type`, `vcs-url`, and `vcs-ref` as well. Is it able to automate adding those labels into the image with OSBS as well? `` To reply, visit the link below or just reply to this email https://pagure.io/atomic-wg/issue/256 _______________________________________________ cloud mailing list -- cloud@lists.fedoraproject.org To unsubscribe send an email to cloud-le...@lists.fedoraproject.org
