ApiServer: Process through chain of api access checker, on failure it will 
throw exception

Signed-off-by: Rohit Yadav <[email protected]>


Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/8f27c711
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/8f27c711
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/8f27c711

Branch: refs/heads/cloud-agent-with-openvswitch
Commit: 8f27c711e58e447409fb1b496dfeab9cf4cd7d63
Parents: 0a31945
Author: Rohit Yadav <[email protected]>
Authored: Mon Jan 14 18:56:02 2013 -0800
Committer: Rohit Yadav <[email protected]>
Committed: Mon Jan 14 19:01:26 2013 -0800

----------------------------------------------------------------------
 server/src/com/cloud/api/ApiServer.java |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/8f27c711/server/src/com/cloud/api/ApiServer.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/api/ApiServer.java 
b/server/src/com/cloud/api/ApiServer.java
index c8511b2..4d60215 100755
--- a/server/src/com/cloud/api/ApiServer.java
+++ b/server/src/com/cloud/api/ApiServer.java
@@ -786,9 +786,7 @@ public class ApiServer implements HttpRequestHandler {
         }
 
         for (APIChecker apiChecker : _apiAccessCheckers) {
-            // Fail the checking if any checker fails to verify
-            if (!apiChecker.checkAccess(user, commandName))
-                return false;
+            apiChecker.checkAccess(user, commandName);
         }
         return true;
     }

Reply via email to