Updated Branches: refs/heads/4.1 48368263a -> 5dbd33d8a
Add missing break to applyRules in FirewallManager Otherwise it would falling through PortForwarding rule. Seems like a typo after network refactor. Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/5dbd33d8 Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/5dbd33d8 Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/5dbd33d8 Branch: refs/heads/4.1 Commit: 5dbd33d8ab6aa345fa603329a92990db53ad754c Parents: 72234ef Author: Sheng Yang <[email protected]> Authored: Tue Feb 12 20:21:20 2013 -0800 Committer: Sheng Yang <[email protected]> Committed: Tue Feb 12 20:26:52 2013 -0800 ---------------------------------------------------------------------- .../network/firewall/FirewallManagerImpl.java | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/5dbd33d8/server/src/com/cloud/network/firewall/FirewallManagerImpl.java ---------------------------------------------------------------------- diff --git a/server/src/com/cloud/network/firewall/FirewallManagerImpl.java b/server/src/com/cloud/network/firewall/FirewallManagerImpl.java index 0d17ba7..080f7b0 100644 --- a/server/src/com/cloud/network/firewall/FirewallManagerImpl.java +++ b/server/src/com/cloud/network/firewall/FirewallManagerImpl.java @@ -545,6 +545,7 @@ public class FirewallManagerImpl extends ManagerBase implements FirewallService, if (handled) break; } + break; case PortForwarding: for (PortForwardingServiceProvider element: _pfElements) { Network.Provider provider = element.getProvider();
