Updated Branches: refs/heads/master 0b84958a6 -> cdae53a28
CLOUDSTACK-1514 : Unable to remove secondary ips though there are no PF rules associated with it Fixed the search filter in PortForwardingRulesDaoImpl.java. Earlier we were passing a wrong filter parameter "address" in listByDestIpAddr which doesn't exist. Changed this to the right search criteria that uses dstIp as filter parameter. Signed-off-by: Venkata Swamybabu Budumuru <[email protected]> Signed-off-by: Sateesh Chodapuneedi <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/cdae53a2 Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/cdae53a2 Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/cdae53a2 Branch: refs/heads/master Commit: cdae53a28914507b32545b37b836ea5aca8bbd83 Parents: 0b84958 Author: Venkata Swamybabu Budumuru <[email protected]> Authored: Tue Mar 5 13:42:07 2013 -0500 Committer: Sateesh Chodapuneedi <[email protected]> Committed: Wed Mar 6 10:28:37 2013 +0530 ---------------------------------------------------------------------- .../rules/dao/PortForwardingRulesDaoImpl.java | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/cdae53a2/server/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java ---------------------------------------------------------------------- diff --git a/server/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java b/server/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java index 5d0b01c..cc780cb 100644 --- a/server/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java +++ b/server/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java @@ -155,7 +155,7 @@ public class PortForwardingRulesDaoImpl extends GenericDaoBase<PortForwardingRul @Override public List<PortForwardingRuleVO> listByDestIpAddr(String ip4Address) { SearchCriteria<PortForwardingRuleVO> sc = AllFieldsSearch.create(); - sc.setParameters("address", ip4Address); + sc.setParameters("dstIp", ip4Address); return listBy(sc); }
