-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5678/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
When creating a basic network configuration with
tools/marvin/marvin/deployDataCenter.py, the command to create the guest ip
ranges will fail.
2012-06-29 14:08:03,831 ERROR [cloud.api.ApiDispatcher] (catalina-exec-7:null)
Exception while executing CreateVlanIpRangeCmd:
java.lang.NullPointerException
at
com.cloud.configuration.ConfigurationManagerImpl.createVlanAndPublicIpRange(ConfigurationManagerImpl.java:2144)
at
com.cloud.utils.component.ComponentLocator$InterceptorDispatcher.intercept(ComponentLocator.java:1189)
at
com.cloud.api.commands.CreateVlanIpRangeCmd.execute(CreateVlanIpRangeCmd.java:164)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:134)
at com.cloud.api.ApiServer.queueCommand(ApiServer.java:538)
at com.cloud.api.ApiServer.handleRequest(ApiServer.java:418)
at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:300)
at com.cloud.api.ApiServlet.doGet(ApiServlet.java:59)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
at
org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:555)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
at
org.apache.coyote.http11.Http11NioProcessor.process(Http11NioProcessor.java:886)
at
org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:721)
at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:2256)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at java.lang.Thread.run(Thread.java:679)
When using basic networking and not specifying the network, the code needs to
fetch the network as well.
Diffs
-----
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 078916e
Diff: https://reviews.apache.org/r/5678/diff/
Testing
-------
Guest IP ranges are created correctly after this change.
Thanks,
Jason Bausewein
