----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5806/ -----------------------------------------------------------
(Updated July 10, 2012, 1:32 p.m.) Review request for cloudstack. Changes ------- Updated the createSnapshot method to decrement the resource count at one place (in the finally code block) for all errors. Description ------- Change: 1. Before creating the snapshot, we synchronized checkResourcelimit to allow the users to create the snapshot and increment the resource count. 2. Depending on the failure of snapshot creation/ backup, we are decrementing the resource count. This addresses bug CS-15430. Diffs (updated) ----- server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java 50dcf38 Diff: https://reviews.apache.org/r/5806/diff/ Testing ------- Steps to verify: 1.Login as admin, set snapshot limit '3' for a user account 2.login as user, create a VM1 with data volume 3.trigger 3 create snapshot command from the above data volume, succeeded 4.create one more snapshot, failed, "maximum limit exceeded for account user" Thanks, deepti dohare
