----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5927/#review9131 -----------------------------------------------------------
Ship it! Ship It! - Nitin Mehta On July 13, 2012, 6:46 a.m., Prasanna Santhanam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5927/ > ----------------------------------------------------------- > > (Updated July 13, 2012, 6:46 a.m.) > > > Review request for cloudstack, Prachi Damle and Nitin Mehta. > > > Description > ------- > > CS-15560 : Improve HVM logging of hosts > > When a host is not considered for deployment because it has disabled HVM, > then call that out in the logs for debugging. > > > This addresses bug CS-15560. > > > Diffs > ----- > > server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java > 0f163cc > > Diff: https://reviews.apache.org/r/5927/diff/ > > > Testing > ------- > > 1) Deployed a Simulator Environment with two Simulator hosts > 2) marked a host as non-HVM and template as HVM enabled > * update host set capabilities=NULL where id=1; > * update vm_template set hvm=1 where id=10; > 3) restart MS for the VOs to refresh > 4) deploy VM using the template > 5) Verified the non-HVM hosts are called out in the logs > > Logs shown as below: > 2012-07-13 12:07:58,904 DEBUG [allocator.impl.FirstFitAllocator] > (Job-Executor-9:job-30 FirstFitRoutingAllocator) Not considering hosts: > [Host[-1-Routing]] to deploy template: Tmpl[10-VHD-simulator-Centos as they > are not HVM enabled > > > Thanks, > > Prasanna Santhanam > >
