----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5930/#review9414 -----------------------------------------------------------
Ship it! Ship It! - Alena Prokharchyk On July 24, 2012, 5:28 p.m., Saksham Srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5930/ > ----------------------------------------------------------- > > (Updated July 24, 2012, 5:28 p.m.) > > > Review request for cloudstack and Alena Prokharchyk. > > > Description > ------- > > Changes done: Added the restriction on listing ISOs by not allowing total no. > of ISOs on a page to exceed the page size. > Made a check on the total public ISOs on a page not to repeat infinetly. > > > This addresses bug CS-12707. > > > Diffs > ----- > > server/src/com/cloud/storage/dao/VMTemplateDao.java ed80aae > server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 1db12aa > > Diff: https://reviews.apache.org/r/5930/diff/ > > > Testing > ------- > > Verified the fix from both UI and API calls.UI does not show repeating ISOs > and API does not list any ISOs for a invalid page request-parameter. > > > Thanks, > > Saksham Srivastava > >
