-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6226/
-----------------------------------------------------------
Review request for cloudstack, Brian Federle, Jessica Wang, and Alena
Prokharchyk.
Description
-------
fix two issues:
1) advanced zone, admin user, zone-->specified zone-->physical network-->guest
network-->network, this pages failed to show any direct tagged network
2) API listNetworks with parameter domainId does not work as document specified
changes:
-NetworkManagerImpl.java
add domainId filter in the end of method searchForNetworks
use Set to remove potentially duplicate returning elements
remove line 'sc.addAnd("id", SearchCriteria.Op.SC, accountSC);' in method
listAccountSpecificNetworksByDomainPath, this line caused issue 1)
-instanceWizard.js
remove parameter 'domainId' of listNetworks
Diffs
-----
server/src/com/cloud/network/NetworkManagerImpl.java 4dd5eab
ui/scripts/instanceWizard.js 3cf6694
Diff: https://reviews.apache.org/r/6226/diff/
Testing
-------
following scenarios are tested?
login as admin, zone-->specified zone-->physical network-->guest
network-->network, can view all networks.
login as a user, create vm from wizard, can see zone-wide,domain-wide and this
account-specific direct tagged networks.
listNetworks API, specficied domainID, listAll=true, return networks belong to
this domain and visible to caller.
Thanks,
mice xia
