One point of clarification - we're using a shared ASF install, no? There's been a few questions this week about adding functionality, I don't think it's gonna be quite that easy….
On Aug 1, 2012, at 7:40 AM, Abhinandan Prateek wrote: Can review board software be programmed so that it does not remove author information from the submitted patches. This will make it easy to submit patches and will avoid user error where author information get replaced. -abhi -----Original Message----- From: Nitin Mehta [mailto:nitin.me...@citrix.com] Sent: Saturday, July 07, 2012 4:01 AM To: cloudstack-dev@incubator.apache.org<mailto:cloudstack-dev@incubator.apache.org> Subject: RE: signing off patches Yes, I had the same issue as well and sadly review board was not helpful for committing the code. I had to do all the hacks like changing the author info, putting in signed off info manually. That is not the way to go. Either review board should have good integration with submitting the git patches or we should switch to a tool which does. -----Original Message----- From: Sheng Yang [mailto:sh...@yasker.org] Sent: Saturday, July 07, 2012 1:17 AM To: cloudstack-dev@incubator.apache.org<mailto:cloudstack-dev@incubator.apache.org> Subject: Re: signing off patches On Fri, Jul 6, 2012 at 6:51 AM, David Nalley <da...@gnsa.us<mailto:da...@gnsa.us>> wrote: git commit has a --author argument http://www.kernel.org/pub/software/scm/git/docs/git-commit.html Reviewboard removed author information is annoying. Otherwise git-am would do the trick(and force contributor to respect coding style) well. Anyway to download original file from Reviewboard? I don't think we're the only one got this problem. BTW, in Linux kernel community(and Xen/KVM), the original author is Author, and maintainer(committor in our case) would do Signed-off-by: to indicate who accepted this patch. Probably we can borrow some ideas here. --Sheng --David On Fri, Jul 6, 2012 at 7:48 AM, Abhinandan Prateek <abhinandan.prat...@citrix.com<mailto:abhinandan.prat...@citrix.com>> wrote: -----Original Message----- From: Prasanna Santhanam [mailto:prasanna.santha...@citrix.com] Sent: Friday, July 06, 2012 4:39 PM To: cloudstack-dev@incubator.apache.org<mailto:cloudstack-dev@incubator.apache.org> Subject: Re: signing off patches On Fri, Jul 06, 2012 at 07:01:58AM -0400, Abhinandan Prateek wrote: After reviewing patches on *review board* downloaded the patch using "Download Diff". The downloaded patch removes the author information. Is it the right way to download patch or is there some problem with the download functionality ? -abhi I see my name against the commit: ce7bc5fb26403c5036643278532d9e04a9fd287a I sent through review- board Does it matter if the patch was signed-off by the author? -- Prasanna., It will be good if we have both author and committer in the committed patch. -abhi Stratosec<http://stratosec.co> - Secure Infrastructure as a Service o: 415.315.9385 @johnlkinsella<http://twitter.com/johnlkinsella>
