I'll do the merge based on the assumption that the patch is already reviewed since Hugo and someone else both looked at it. I myself don't know maven at all. Gives me an opportunity to learn. If the assumption is incorrect, someone with maven knowledge please let me know I should hold off and review the branch.
Thanks. --Alex > -----Original Message----- > From: Alex Huang > Sent: Thursday, August 23, 2012 9:10 AM > To: [email protected] > Subject: RE: maven patch > > I'll do it today. > > --Alex > > > -----Original Message----- > > From: Darren Shepherd [mailto:[email protected]] > > Sent: Thursday, August 23, 2012 8:21 AM > > To: [email protected] > > Subject: maven patch > > > > Some Committer, > > > > I can't seem to get the maven patch to work through Review Board. Can > > a committer just pull the "maven" branch from > > https://github.com/ibuildthecloud/incubator-cloudstack.git merge to > > master and commit? One of the problems with the patch is that it > > moves deps/XenServerJava/com to deps/XenServerJava/src/com. With a > > patch that shows as a delete and add, not a move. Besides moving that > > directory the patch is non-impacting in that it just adds the pom.xml files > everywhere. > > The summary of the diff will show that its just a bunch of adds. > > > > Darren > > > > > >
