No problems Chip. Just that while adding headers in a JSP file , it does not accept <!-- comment --> as the correct syntax for putting a comment , since JSP comments are of the form -
<%-- this is a comment --%> Thanks for verifying my changes , Chip . Regards, Pranav -----Original Message----- From: Chip Childers [mailto:[email protected]] Sent: Wednesday, August 29, 2012 7:58 PM To: Pranav Saxena Cc: [email protected]; Sonny Chhen; Brian Federle; Jessica Wang Subject: Re: IE compatibility broken because of License Headers added to the JSP file issue fixed Pranav, They look fine. Sorry about breaking things, and thanks for fixing it. -chip On Wed, Aug 29, 2012 at 2:12 AM, Pranav Saxena <[email protected]> wrote: > Hey Chip , > > > > I happened to notice that one of the check-ins made by you for adding > the license headers to the index.jsp file under the UI folder was > breaking the CloudStack UI compatibility with IE . So I have made > the appropriate changes to fix this issue. Could you please verify > the changes and suggest if they look ok to you ? > > > > This is your commit - > > commit 7998362b1877e629c5d43e25202f5cc30c001d04 > > Author: Chip Childers <[email protected]> > > Date: Fri Aug 3 12:45:47 2012 -0400 > > > > License header updates for the UI folder > > > > > > This is my commit - > > > > Fixing UI compatibility with IE which was broken because of license > headers added to jsp file > > > > > > Project: > http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo > > Commit: > http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/d7b > 249fb > > Tree: > http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/d7b24 > 9fb > > Diff: > http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/d7b24 > 9fb > > > > Branch: refs/heads/master > > Commit: d7b249fb01cc05e46fade8f23d7e6fbc255866b5 > > Parents: 8884feb > > Author: Pranav Saxena <[email protected]> > > Authored: Wed Aug 29 11:35:28 2012 +0530 > > Committer: Pranav Saxena <[email protected]> > > Committed: Wed Aug 29 11:35:28 2012 +0530 > > > > Thanks, > > Pranav
