> On Sept. 4, 2012, 5:06 p.m., edison su wrote: > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java, > > line 1416 > > <https://reviews.apache.org/r/6883/diff/3/?file=149124#file149124line1416> > > > > How about changing the logic to: > > for (InterfaceDef pluggedNic : pluggedNics) { > > if (pluggedVlanBr.equalsIgnoreCase(_publicBridgeName)) { > > if (pubVlan.equalsIgnoreCase(pluggedVlanId)) { > > break; > > } > > } > > devNum++ > > }
This is where not understanding the actual implementation requirements comes into play. Do we only ever want to pass the one public.network.device that the agent knows of? In the past you've said there could potentially be multiple public bridges that we need to search through, not just the one defined in the agent config. My initial implementation looked for _publicBridgeName and used that. Your implementation here does the same, but verifies that it's also on the same vlan that we're looking for before using it (whether a vlan num or untagged). It doesn't satisfy your previous comment about looking at multiple bridges to find a match, it only matches the one public.network.device in the agent's config. - Marcus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6883/#review11020 ----------------------------------------------------------- On Sept. 3, 2012, 7:37 p.m., Marcus Sorensen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6883/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2012, 7:37 p.m.) > > > Review request for cloudstack. > > > Description > ------- > > Implements > SetupGuestNetworkCommand,SetNetworkACLCommand,SetSourceNatCommand,IpAssocVpcCommand,SetPortForwardingRulesVpcCommand. > Passes basic functionality, though I'm sure there may be some honing to do. > > Also fixes a few minor things found along the way: > vpc_guestnw.sh wasn't successfully setting up apache due to default listen > IP of 10.1.1.1 > vpc_guestnw.sh was referencing a 'logger_it' function, replaced with 'logger > -t cloud' > system vms were running with OS type "Debian GNU/Linux 5.0(32-bit)", which > was not found in the KVMGuestOsMapper > the Xen implementation of SetupGuestNetworkCommand had apparently copied its > catch message from UnPlug Nic, fixed string > > > Diffs > ----- > > > core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java > 965dd63 > patches/systemvm/debian/config/opt/cloud/bin/vpc_guestnw.sh be0ad96 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/KVMGuestOsMapper.java > e3615ad > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > 7e8a11c > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > a6efdf7 > > Diff: https://reviews.apache.org/r/6883/diff/ > > > Testing > ------- > > created VPC, added 3 tiers, added 3 vms, set up acls for ICMP between all > tiers, TCP outbound on all tiers. Tested traffic between VMs on all three > networks. Added IPs, created portforwarding rule port 22 to VM on network 3, > added TCP port 22 ingress rule for network 3, SSH'ed into the VM via public > IP. Rebooted VPC router and tested everything again. > > > Thanks, > > Marcus Sorensen > >
