IMO, if it's generated we can. I would suggest adding the ASF header to it, just like we did for the generated java files.
- chip Sent from my iPhone. On Sep 5, 2012, at 6:33 PM, Prachi Damle <[email protected]> wrote: > Nope. But the file seems to have been generated using the AWS wsdl... I guess > if we can use the generated code, we could use this as well? > > -----Original Message----- > From: Chip Childers [mailto:[email protected]] > Sent: Wednesday, September 05, 2012 3:09 PM > To: Prachi Damle > Cc: Hugo Trippaers; [email protected] > Subject: Re: RPM build fixed (maven-waf branch) > > Prachi, > > Do you remember / know specifically where the services file came from? > > - chip > > Sent from my iPhone. > > On Sep 5, 2012, at 5:49 PM, Prachi Damle <[email protected]> wrote: > >> Hugo / Chip, >> >> I tested and found that we need to include the services.xml file in aar file >> generated by build - without that axis2 cannot deploy the aar files when you >> start cloudstack. >> We can remove the AmazonEC2.wsdl file safely. >> >> Are there any issues with having services.xml file in source tree? >> >> [java] org.apache.axis2.deployment.DeploymentException: The services.xml >> fie cannot be found for the service: >> C:\tomcat\apache-tomcat-6.0.29\webapps7080\asapi\WEB-INF\services\cloud-ec2.aar >> [java] at >> org.apache.axis2.deployment.repository.util.ArchiveReader.proessServiceGroup(ArchiveReader.java:150) >> >> >> Hugo, the test procedure I use is: >> - remove files and build >> - deploy CloudStack >> - create user and generate keys >> - enable ec2 in CloudStack >> >> For client: >> - register the user's certificate and set up EC2 tools environment >> - use ec2 tools to test commands against CloudStack ec2 api. >> >> Thanks, >> -Prachi >> >> -----Original Message----- >> From: Hugo Trippaers [mailto:[email protected]] >> Sent: Wednesday, September 05, 2012 2:08 PM >> To: Prachi Damle >> Cc: Chip Childers; [email protected] >> Subject: Re: RPM build fixed (maven-waf branch) >> >> Prachi, >> >> Would it be possible to describe the test procedure? Maybe we can add it to >> Jenkins as well. >> >> Cheers, >> >> Hugo >> >> Sent from my iPhone >> >> On 5 sep. 2012, at 23:04, "Prachi Damle" <[email protected]> wrote: >> >>> The aar files contain the wsdl file and the services.xml file because the >>> build script includes them specifically while building the aar. >>> >>> I don't know if these are a must have files in aar. I will remove and check >>> if things work. >>> >>> -Prachi >>> -----Original Message----- >>> From: Chip Childers [mailto:[email protected]] >>> Sent: Wednesday, September 05, 2012 1:57 PM >>> To: Hugo Trippaers >>> Cc: [email protected]; Prachi Damle >>> Subject: Re: RPM build fixed (maven-waf branch) >>> >>> On Wed, Sep 5, 2012 at 4:44 PM, Hugo Trippaers >>> <[email protected]> wrote: >>>> Chip, >>>> >>>> That makes more sense and less work :-). I think i have the maven part >>>> done now. The only thing i'm curious about is the mar and aar files. They >>>> seem to contain the wsdl files as well. I now nothing about axis2 so no >>>> idea what is needed to get awaapi to work right. >>> >>> Might need some help from the folks that have worked on it in the >>> past >>> ;) >>> >>> IIRC, aar files are the result of an axis build. I don't see any of them >>> in the source tree though... do you? >>> >>> The only mar files I see are the modules/rahas-1.5.mar and >>> modules/rampart-1.5.mar, which I think are basically dependency files. >>> I did a quick search on maven central, and I think the ones we need are >>> there: >>> >>> http://search.maven.org/#search%7Cga%7C1%7Crahas >>> http://search.maven.org/#search%7Cga%7C1%7Crampart >>> >>> Can we make them pull from the mvn central and get them out of the source >>> tree? >>> >>> >>>> >>>> Cheers, >>>> >>>> Hugo >>>> >>>> Sent from my iPhone >>>> >>>> On 5 sep. 2012, at 21:43, "Chip Childers" <[email protected]> >>>> wrote: >>>> >>>>> On Wed, Sep 5, 2012 at 6:40 AM, Hugo Trippaers >>>>> <[email protected]> wrote: >>>>>> Hey Rajesh, >>>>>> >>>>>> As far as I understand (and please correct me if I'm wrong) awsapi >>>>>> consists of three parts. The generated code for ec2, the generated code >>>>>> for s3 and "our" code. I would like to split this in three subprojects >>>>>> for maven. Two using the maven axis2 plugins to generate the classes and >>>>>> a third that uses the output from the first two (the .mar and .aar >>>>>> files) and makes the webapp by adding "our" code. >>>>>> >>>>>> Does that make sense? >>>>> >>>>> Hugo, >>>>> >>>>> I think we were trying to get the WSDL files out of the source tree. >>>>> Prachi did some work on this initially, but two files still remain. >>>>> I believe that without a clear license for the WSDL files, we might >>>>> need to remove them from the tree. Given that, the generated >>>>> classes can stay (and be licensed by ASF). If that's the case, >>>>> then this really only needs to be one maven project. Does that make >>>>> sense? >>>>> >>>>> The files in question are: >>>>> >>>>> incubator-cloudstack/awsapi/resource/AmazonEC2/AmazonEC2.wsdl >>>>> incubator-cloudstack/awsapi/resource/AmazonEC2/services.xml >>>>> >>>>> Prachi - I'm not sure that you were able to come back around to my >>>>> previous questions about this, but do you think we can remove them >>>>> as well? >>>>> >>>>> Rajesh, perhaps you know the answer? >>>>> >>>>> -chip >>>>> >>>>>> >>>>>> Cheers, >>>>>> >>>>>> Hugo >>>>>> >>>>>>> -----Original Message----- >>>>>>> From: Rajesh Battala [mailto:[email protected]] >>>>>>> Sent: Wednesday, September 05, 2012 12:32 PM >>>>>>> To: [email protected] >>>>>>> Subject: RE: RPM build fixed (maven-waf branch) >>>>>>> >>>>>>> Hi Hugo, >>>>>>> >>>>>>> Regarding Awsapi how are you planning to go ahead ? >>>>>>> >>>>>>> Thanks >>>>>>> Rajesh Battala >>>>>>> -----Original Message----- >>>>>>> From: Hugo Trippaers [mailto:[email protected]] >>>>>>> Sent: Wednesday, September 05, 2012 3:43 PM >>>>>>> To: [email protected] >>>>>>> Subject: RPM build fixed (maven-waf branch) >>>>>>> >>>>>>> Heya, >>>>>>> >>>>>>> I've made a new branch 'maven-waf' containing the stuff needed to >>>>>>> build RPM's using the maven and waf. I've fixed the issues that >>>>>>> prevented building from a clean tree directly, so it should be >>>>>>> complete now. With the exeption of awsapi, see my earlier mail on that >>>>>>> one. >>>>>>> >>>>>>> Cheers, >>>>>>> >>>>>>> Hugo >>>>>> >>>>>> >>>> >> >
