----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7025/#review11338 -----------------------------------------------------------
Both methods generateVmDataCommand() contain a lot of duplicated code. Please take out whatever is common for the methods, and extract it to the separate method. - Alena Prokharchyk On Sept. 11, 2012, 5:30 p.m., Fang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7025/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2012, 5:30 p.m.) > > > Review request for cloudstack and Alena Prokharchyk. > > > Description > ------- > > For pre 3.0.x, there is no uuid generated for vm instance. Keep the vm-id and > instance-id the original value, instead > of using uuid. > > > This addresses bug CS-15627. > > > Diffs > ----- > > server/src/com/cloud/network/element/CloudZonesNetworkElement.java 0d4c1c1 > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > 613548b > > Diff: https://reviews.apache.org/r/7025/diff/ > > > Testing > ------- > > Tested on upgrade. > > > Thanks, > > Fang Wang > >
