----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7109/#review11636 -----------------------------------------------------------
This builds fine for me locally with the few fixes requested below. docs/en-US/primary-storage-add.xml <https://reviews.apache.org/r/7109/#comment25139> In the xref tag, change the linkend to "log-in" docs/en-US/secondary-storage-add.xml <https://reviews.apache.org/r/7109/#comment25140> If you could conditionalize the xref for Preparing NFS Shares, we can include this section in the Admin Guide also. Otherwise this creates a build error in the Admin Guide, as the NFS Shares section is not included there. Like this: <phrase condition="install">See <xref linkend="prepare-nfs-shares" />.</phrase> <phrase condition="admin">See Preparing NFS Shares in the Installation Guide.</phrase> You will need to also add the following line to publican-install.cfg and publican-all.cfg: condition:install docs/en-US/secondary-storage-add.xml <https://reviews.apache.org/r/7109/#comment25141> Same comment as for previous line. If you can conditionalize this xref, the section can be included in multiple guides. <phrase condition="install">See <xref linkend="prepare-system-vm-template" />.</phrase> <phrase condition="admin">See Prepare the System VM Template in the Installation Guide.</phrase> docs/en-US/secondary-storage-add.xml <https://reviews.apache.org/r/7109/#comment25142> Can keep zone-add as an xref. Since adding a zone is an ongoing Admin function and is included in the Admin Guide, this does not break the Admin Guide build. - Jessica Tomechak On Sept. 14, 2012, 1:23 p.m., Gavin Lee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7109/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2012, 1:23 p.m.) > > > Review request for cloudstack, David Nalley and Jessica Tomechak. > > > Description > ------- > > docbook xml for adding primary and secondary storage > > > Diffs > ----- > > docs/en-US/primary-storage-add.xml 588d491 > docs/en-US/secondary-storage-add.xml 15e8c74 > > Diff: https://reviews.apache.org/r/7109/diff/ > > > Testing > ------- > > Passed publican build and verified html/pdf output. > > > Thanks, > > Gavin Lee > >
