----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7192/ -----------------------------------------------------------
(Updated Sept. 21, 2012, 11:25 a.m.) Review request for cloudstack, Devdeep Singh and Ram Ganesh. Changes ------- 1. Reviewers updated 2. Testing details updated 3. Updated diff, thrown ResourceUnavailable exception from LB manager. This will enable reverting of LB as well as autoscale states in db. Description ------- All 4 bugs together have minimal code changes; submitting them together. Bug: CS-15931 Delete Vm group not removing configs from NS. Change: Checked for VM Groups current state before removal from NS. Bug: CS-15935 NetScaler sessions increase in case of errors in the NetScaler Change: Added logout before login. Bug: CS-15930 Save config not triggered to NS after create, update delete VM group Change: Saveconfiguration triggered after successful NS API calls. Bug: CS-15934 Handling Resource Unavailable exception for AutoScale Change: If ResourceUnavailableException is caught, the state is reverted. PS: I sincerely hope i have not made any spacing errors. This addresses bugs CS-15930, CS-15931, CS-15934, and CS-15935. Diffs (updated) ----- api/src/com/cloud/agent/api/to/LoadBalancerTO.java 884c7c5 api/src/com/cloud/network/as/AutoScaleService.java ef99512 api/src/com/cloud/network/lb/LoadBalancingRule.java 5c39f31 plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java f2a5278 server/src/com/cloud/network/as/AutoScaleManagerImpl.java 0e5e81b server/src/com/cloud/network/lb/LoadBalancingRulesManager.java ebe4e2a server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 025e441 Diff: https://reviews.apache.org/r/7192/diff/ Testing (updated) ------- Build Successful Tested the bugs as mentioned in Jira, meaning Bug: CS-15931: Deleted AutoScale Vm Group. Bug: CS-15935: Simulate a netscaler error (say have a vserver with same ip/port) and attempt add loadbalancer rule. Same number of sessions should exist in netscaler (use "show system session") before after the operation. Please see bug for more details. Bug: CS-15930: Create autoscale config. Check if configuration is present in /nsconfig/ns.conf in NetScaler. Bug: CS-15934: Create autoscale config, shutdown netscaler vm, restart management server, disable autoscale config. Database should not be changed before and after the operation. Thanks, Vijay Venkatachalam
