Yes, working on to fix it.. Thanks, Pradeep.S
-----Original Message----- From: Chip Childers [mailto:[email protected]] On Behalf Of Chip Childers Sent: Monday, September 24, 2012 8:46 PM To: Chip Childers; Edison Su Cc: cloudstack; Rohit Yadav; Pradeep Soundararajan Subject: Re: Review Request: CLOUDSTACK-43 : Jenkins build process needs to allow for setting the appropriate version number within the built JARs. > On Sept. 24, 2012, 10:56 a.m., Rohit Yadav wrote: > > Ship It! > > Rohit Yadav wrote: > Note: The patch is find, but the refactoring of version tags to top level > pom has one issue. If you now cd to a submodule and do mvn <lifecycle > command>, it will fail in most cases. As submodule poms won't know where to > get global variables. > > One solution in that case is to select a project, we need to build etc., > like mvn -pl <project> > Other solution is to set relative path to parent as done in plugins/** > <parent> > <groupId>org.apache.cloudstack</groupId> > <artifactId>cloudstack-plugins</artifactId> > <version>${cs.version}</version> > <relativePath>../../pom.xml</relativePath> > </parent> > > Rohit Yadav wrote: > Found one more issue. The toplevel pom has version<> > <version>${cs.version}</version> > This fails as the variable declaration is below that. > > To fix this, set the version here around line 31. And use Maven's > reflections to get the variable. Like in submodule use > ${project.parent.version} to get the version resolution from parent. In > plugin/** one may use ${project.parent.parent.version} We probably shouldn't commit this change until the above 2 items are resolved. - Chip ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7083/#review11827 ----------------------------------------------------------- On Sept. 24, 2012, 10:48 a.m., Pradeep Soundararajan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7083/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2012, 10:48 a.m.) > > > Review request for cloudstack, Chip Childers and edison su. > > > Description > ------- > > The Jenkins binary build processes are producing JAR files that contain > version numbers like 4.0.0-SNAPSHOT. We need a way to set a parameter within > the build to set the version from SNAPSHOT to RC1 or even drop the > pre-release identifier entirely (so that we can generate an actual release). > > >> Removed the occurrences of SNAPSHOT > > > Diffs > ----- > > agent/pom.xml a559580 > api/pom.xml db14775 > awsapi/pom.xml a583384 > client/pom.xml 50b85e9 > cloud.spec c1fe56a > console-proxy/pom.xml 8bfb753 > core/pom.xml 510cb04 > debian/cloud-deps.install 74aade1 > deps/XenServerJava/pom.xml 1337514 > deps/pom.xml 1e20083 > patches/pom.xml d62fc86 > plugins/deployment-planners/user-concentrated-pod/pom.xml ca2fae1 > plugins/deployment-planners/user-dispersing/pom.xml 6e1ffc6 > plugins/file-systems/netapp/pom.xml f10e5a4 > plugins/host-allocators/random/pom.xml ad66c0e > plugins/hypervisors/kvm/pom.xml 4863085 > plugins/hypervisors/ovm/pom.xml a8b23d0 > plugins/hypervisors/vmware/pom.xml 435ae38 > plugins/hypervisors/xen/pom.xml bf38e47 > plugins/network-elements/elastic-loadbalancer/pom.xml c1ab2c5 > plugins/network-elements/f5/pom.xml 0cba48c > plugins/network-elements/juniper-srx/pom.xml 38a2b55 > plugins/network-elements/midokura-midonet/pom.xml 7f2e2d3 > plugins/network-elements/netscaler/pom.xml 377e6e0 > plugins/network-elements/nicira-nvp/pom.xml 37c3a3a > plugins/network-elements/ovs/pom.xml 02d455c > plugins/pom.xml 206d4a1 > plugins/storage-allocators/random/pom.xml 6cb60cd > plugins/user-authenticators/ldap/pom.xml 7facc3f > plugins/user-authenticators/md5/pom.xml 1dac92d > plugins/user-authenticators/plain-text/pom.xml a4280a3 > pom.xml 49a71a1 > server/pom.xml f7178d8 > test/pom.xml f70a89f > usage/pom.xml 92e5e72 > utils/pom.xml e8d7827 > vmware-base/pom.xml 1dabe83 > wscript_build 4264822 > > Diff: https://reviews.apache.org/r/7083/diff/ > > > Testing > ------- > > Able to execute mvn install successfully after the changes... > > > Thanks, > > Pradeep Soundararajan > >
