>> On Nov. 22, 2012, 12:05 a.m., Chiradeep Vittal wrote: >> > server/src/com/cloud/vm/UserVmManagerImpl.java, line 3006 >> > <https://reviews.apache.org/r/8172/diff/1/?file=222634#file222634line3006> >> > >> > this is a major piece of surgery on this method. How are you sure that >> > the before and after results are identical? > > I have done a prototype before this checkin and verified that it returns the > same result as before. UserVmJoinVO is view object containing all the fields > before in UserVm interface, no information is lost.
Perhaps we should have tests that establish existing present functionality, and then have those in place before this surgery is performed which could then assure us that the functionality is identical. --David
