-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8632/
-----------------------------------------------------------
(Updated Dec. 17, 2012, 4:15 a.m.)
Review request for cloudstack, Nitin Mehta, edison su, and Marcus Sorensen.
Changes
-------
Including more reviewers
Description
-------
When CleanupSnapshotBackupCommand is sent to the SSVM agent because it needs to
perform storage GC - outdated snapshots remain undeleted. But the answer
returned to mgmt server is success. This is related to CLOUDSTACK-643 where KVM
uses a different path to its snapshot backups that includes the zoneid in the
path.
KVM uses /snapshots/zoneid/accountid/volumeid for its snapshot path. The
cleanupbackupsnapshotcommand which performs GC interprets an invalid path
(as
/snapshots/accountid/volumeid) to the snapshot and fails to delete them from
sec. storage.
Now GC path is corrected so snapshots removed fmor DB are also removed from
secondary storage.
This addresses bug CLOUDSTACK-649.
Diffs
-----
core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java d8fdc3a
Diff: https://reviews.apache.org/r/8632/diff/
Testing
-------
1. Tested create snapshot, delete snapshot
2. Tested recurring snapshot creation , deletion via storage gc
Both scenarios pass
Thanks,
Prasanna Santhanam
