----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8730/#review14788 -----------------------------------------------------------
Looks good, will do test them later. One thing though; get rid of any redundant imports like IdentityMapper imports as they are not used. We want to get rid of IdentityMapper. - Rohit Yadav On Dec. 20, 2012, 11:52 p.m., Prasanna Santhanam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8730/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2012, 11:52 p.m.) > > > Review request for cloudstack, Rohit Yadav and Min Chen. > > > Description > ------- > > API Refactoring: > > 1. Annotated the remote access vpn commands > 2. Listzones command > > > Diffs > ----- > > > api/src/org/apache/cloudstack/api/command/user/vpn/CreateRemoteAccessVpnCmd.java > 4d9e685 > > api/src/org/apache/cloudstack/api/command/user/vpn/DeleteRemoteAccessVpnCmd.java > 38a050a > > api/src/org/apache/cloudstack/api/command/user/vpn/ListRemoteAccessVpnsCmd.java > 210b864 > api/src/org/apache/cloudstack/api/command/user/zone/ListZonesByCmd.java > 7bb6549 > api/src/org/apache/cloudstack/api/response/IPAddressResponse.java d614e34 > api/src/org/apache/cloudstack/api/response/RemoteAccessVpnResponse.java > c8caa43 > > Diff: https://reviews.apache.org/r/8730/diff/ > > > Testing > ------- > > > Thanks, > > Prasanna Santhanam > >
