I think the build failed as only 'mvn clean install' was tried out before the merge. Should building the nonoss components made mandatory as part of the merge process?
-Koushik > -----Original Message----- > From: Rohit Yadav [mailto:[email protected]] > Sent: Thursday, January 10, 2013 12:54 AM > To: Pradeep Soundararajan; [email protected] > Subject: RE: ASF master nonoss build failed > > Thanks for the bug reports, you should open jira tickets for that. > Nevertheless, fixed in: > > commit 999ecb67dfa69a40085279af1d2e19cf5a5f7509 > Author: Rohit Yadav <[email protected]> > Date: Wed Jan 9 11:23:24 2013 -0800 > > plugins: Import and @Parameter fixes > > Signed-off-by: Rohit Yadav <[email protected]> > > commit 4e71a5a7b9b6778a59ffb741249b01be4db7c2ad > Author: Rohit Yadav <[email protected]> > Date: Wed Jan 9 11:22:35 2013 -0800 > > netapp: Fix String conversion method of long id > > Signed-off-by: Rohit Yadav <[email protected]> > > commit 066edc11052ce5527e7624040a8176256959d151 > Author: Rohit Yadav <[email protected]> > Date: Wed Jan 9 11:21:30 2013 -0800 > > plugins: Fix pluggable service getPropertiesFiles() on f5, srx and > netscaler > > Signed-off-by: Rohit Yadav <[email protected]> > > > ________________________________________ > From: Pradeep Soundararajan > Sent: Wednesday, January 09, 2013 9:47 PM > To: Rohit Yadav; [email protected] > Subject: RE: ASF master nonoss build failed > > Hi Rohit, > > Thanks for fixing that error. I see still the issue is exist in different > format of > error :) > > [INFO] Apache CloudStack Plugin - NetApp File System ..... FAILURE [1.766s] > ............ > ........... > ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler- > plugin:2.5.1:compile (default-compile) on project cloud-plugin-netapp: > Compilation failure [ERROR] NetappManagerImpl.java:[663,35] long cannot > be dereferenced > > Thanks, > Pradeep S > > > -----Original Message----- > From: Rohit Yadav > Sent: Wednesday, January 09, 2013 7:17 PM > To: [email protected]; Pradeep Soundararajan > Subject: RE: ASF master nonoss build failed > > For now I've re-added and partially reverted the change so the interfaces are > available to the exception interface; see the commit messages for TODOs > and FIXME. Pradeep, pl. open a jira ticket on this issues. Thanks; > > commit 7c5c3c5dfcc985dfd6dd890c96fa840a2bac3e0e > Author: Rohit Yadav <[email protected]> > Date: Wed Jan 9 05:43:41 2013 -0800 > > api: Re-add deleted addProxyObject method on CloudException > > - This was removed part of the response work > - Re-adding as this kind of method definition is available in several > other > exception classes and is used in a lot of cmd classes and in service > layer > - TODO: We need to find a way to replace old code and refactor method > with the > new definition that gets only uuid. > - FIXME: Some tables don't have uuid for ex. ClusterVSMMapVO, in this > case > we should keep the method until we find a way to fix this issue > > Partially reverting a88ce6bb7f495dddeb954d1fc7826176646b3590 > > Signed-off-by: Rohit Yadav <[email protected]> > > diff --git a/api/src/com/cloud/exception/CloudException.java > b/api/src/com/cloud/exception/CloudException.java > index fd83956..2ec6142 100644 > --- a/api/src/com/cloud/exception/CloudException.java > +++ b/api/src/com/cloud/exception/CloudException.java > @@ -56,6 +56,15 @@ public class CloudException extends Exception { > return; > } > > + public void addProxyObject(Object voObj, Long id, String idFieldName) { > + // Get the VO object's table name. > + String tablename = AnnotationHelper.getTableName(voObj); > + if (tablename != null) { > + addProxyObject(tablename, id, idFieldName); > + } > + return; > + } > + > > > ________________________________________ > From: Rohit Yadav [[email protected]] > Sent: Wednesday, January 09, 2013 7:10 PM > To: Pradeep Soundararajan; [email protected] > Subject: RE: ASF master nonoss build failed > > Hi Pradeep, > > That is part of the response change. ClusterVSMMapVO does not have a uuid > column and the addProxyObject with args definition > (java.lang.String,long,java.lang.String) was removed and replaced with > (java.lang.String). > I don't know the best way to fix this, I can re-add the deleted/old method > and keep both of the methods; a lot of exception classes have > addProxyObject with the definition that accepts tablename, id and column, > I'm not sure if we want the old methods or have them replaces by new one > (uuid one will help us escape manually putting table name for all exceptions). > > Pl. open a jira issue and assign to Min, she would be able to suggest the best > way to fix it, also because there are a lot of cmd classes and managerimpls > (service layer) where this pattern can be seen. > > Git commit in which the old method was removed: > > commit a88ce6bb7f495dddeb954d1fc7826176646b3590 > Author: Min Chen <[email protected]> > Date: Wed Dec 19 23:49:44 2012 -0800 > > Remove IdentityProxy from CloudException and ExceptionResponse. > > diff --git a/api/src/com/cloud/exception/CloudException.java > b/api/src/com/cloud/exception/CloudException.java > index 8cfae21..fd83956 100644 > --- a/api/src/com/cloud/exception/CloudException.java > +++ b/api/src/com/cloud/exception/CloudException.java > @@ -30,7 +30,7 @@ import com.cloud.utils.AnnotationHelper; public class > CloudException extends Exception { > > // This holds a list of uuids and their names. Add uuid:fieldname > pairs > - protected ArrayList<IdentityProxy> idList = new > ArrayList<IdentityProxy>(); > + protected ArrayList<String> idList = new ArrayList<String>(); > > protected Integer csErrorCode; > > @@ -44,26 +44,19 @@ public class CloudException extends Exception { > > setCSErrorCode(CSExceptionErrorCode.getCSErrCode(this.getClass().getNam > e())); > } > > - public void addProxyObject(Object voObj, Long id, String idFieldName) { > - // Get the VO object's table name. > - String tablename = AnnotationHelper.getTableName(voObj); > - if (tablename != null) { > - addProxyObject(tablename, id, idFieldName); > - } > - return; > - } > + > > public CloudException() { > super(); > > setCSErrorCode(CSExceptionErrorCode.getCSErrCode(this.getClass().getNam > e())); > } > > - public void addProxyObject(String tableName, Long id, String > idFieldName) { > - idList.add(new IdentityProxy(tableName, id, idFieldName)); > + public void addProxyObject(String uuid) { > + idList.add(uuid); > > > ________________________________________ > From: Pradeep Soundararajan > Sent: Wednesday, January 09, 2013 6:37 PM > To: Rohit Yadav > Subject: RE: ASF master nonoss build failed > > [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler- > plugin:2.5.1:compile (default-compile) on project cloud-plugin-hypervisor- > vmware: Compilation failure [ERROR] > CiscoNexusVSMDeviceManagerImpl.java:[345,26] > addProxyObject(java.lang.String) in com.cloud.exception.CloudException > cannot be applied to (java.lang.String,long,java.lang.String) > [ERROR] -> [Help 1] > > Please find the next error :) > > I am using the command: mvn install -Dnonoss > > > -----Original Message----- > From: Rohit Yadav [mailto:[email protected]] > Sent: Wednesday, January 09, 2013 6:28 PM > To: [email protected] > Subject: RE: ASF master nonoss build failed > > Oops, my mistake, the interface definition change to array of strings. > > Fixed in: > commit 2eee2cd999889d105395621eb1f22103ca6f51c5 > Author: Rohit Yadav <[email protected]> > Date: Wed Jan 9 04:56:32 2013 -0800 > > plugins: Fix getPropertiesFiles() for pluggable service plugins, > CiscoNexusVSMEElement > > > Thanks for bringing this, pl. run it again and let me know if it fails for > some > other reasons. > > Regards. > ________________________________________ > From: Pradeep Soundararajan [[email protected]] > Sent: Wednesday, January 09, 2013 6:15 PM > To: [email protected] > Subject: ASF master nonoss build failed > > I have noticed today non-oss build on ASF master failed. Till yesterday it > was > going fine. I have copied the entire logs here: http://pastebin.com/JmRnYLiY > > Snippet of the error message: > > [INFO] Apache CloudStack Plugin - Hypervisor VMware ...... FAILURE [3.699s] > .......... > .......... > .......... > [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler- > plugin:2.5.1:compile (default-compile) on project cloud-plugin-hypervisor- > vmware: Compilation failure: Compilation failure: > [ERROR] CiscoNexusVSMDeviceManagerImpl.java:[345,26] > addProxyObject(java.lang.String) in com.cloud.exception.CloudException > cannot be applied to (java.lang.String,long,java.lang.String) > [ERROR] CiscoNexusVSMElement.java:[62,7] > com.cloud.network.element.CiscoNexusVSMElement is not abstract and > does not override abstract method getPropertiesFiles() in > com.cloud.utils.component.PluggableService > [ERROR] CiscoNexusVSMElement.java:[239,4] method does not override or > implement a method from a supertype > > Thanks, > Pradeep S
