> On Jan. 10, 2013, 12:38 a.m., Chiradeep Vittal wrote: > > server/src/com/cloud/agent/manager/DirectAgentAttache.java, line 57 > > <https://reviews.apache.org/r/8855/diff/2/?file=245661#file245661line57> > > > > We cannot assume that the Daos will be loaded before this static > > initializer is called. The order of calling static initializers is not > > defined. It is better to initialize it via the AgentManagerImpl
Fixed in latest update - Koushik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8855/#review15219 ----------------------------------------------------------- On Jan. 15, 2013, 7:09 a.m., Koushik Das wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8855/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2013, 7:09 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Alex Huang. > > > Description > ------- > > Currently the DirectAgent pool size is hard-coded to 500. One of the factors > that can affect this is the number of hosts in a deployment. If there are > more than 500 hosts (say around 1K) then this pool can easily get exhausted > resulting in delays and undesired behavior. > > Removed hard-coding of directagent thread pool size and now reading it from > configuration. > > > This addresses bug CLOUDSTACK-810. > > > Diffs > ----- > > server/src/com/cloud/agent/manager/AgentManagerImpl.java 8141fdb > server/src/com/cloud/agent/manager/DirectAgentAttache.java 848c7e6 > server/src/com/cloud/configuration/Config.java b91fbdd > setup/db/db/schema-40to410.sql bf3fb30 > > Diff: https://reviews.apache.org/r/8855/diff/ > > > Testing > ------- > > Verified that configuration entry is present in the 'configuration' table. > Also verified in a debugger that it is read correctly while creating the > directagent thread pool. > > > Thanks, > > Koushik Das > >
