[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562949#comment-13562949
 ] 

Noa Resare commented on CLOUDSTACK-792:
---------------------------------------

I'm unsure about what you mean by your question. I'm guessing I have 
misunderstood something, but this is my read on the situation:

The patch applies cleanly to current master (8f11f631)

Three issues has been raised by the strategy chosen in the patch. The first 
would be that it would be that avoiding absolute paths unless neeed makes the 
functionality more robust. I updated the diff in response to this.

The second one is edison's input that there already is a pattern of 
parameterization of actions that maven takes. I argue that the patch as it 
stands is simpler (and more useful) than the method that he proposes, as it 
would "just work" for all but the most esoteric setups

Third issue raised — your assertion that genisoimage would be too different 
from mkisofs for this to be a valid strategy — seems like a difficult claim to 
make to make as it turns that the two tools are literally identical on at least 
one supported operating environment.

So, I'm under the impression that I have responded to the issues raised. Do I 
need to do anything more?

                
> make maven use mkisofs or genisoimage depending on what is available
> --------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-792
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-792
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Noa Resare
>            Priority: Minor
>
> Due to differing licensing philosophies between the Debian project and the 
> mkisofs maintainer the tool will probably never be shipped as part of Debian.
> There is a tool named genisoimage that is command line parameter compatible 
> with mkisofs and does the same thing.
> It would be useful to have maven pick this difference up and handle both 
> cases.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to