Rohit, Murali Can you review the patch? Is patch still valid after Network refactoring
> -----Original Message----- > From: Hiroaki Kawai [mailto:[email protected]] On Behalf Of > Hiroaki Kawai > Sent: Friday, November 30, 2012 4:18 AM > To: cloudstack; Hiroaki Kawai > Subject: Review Request: Store NetworkServiceProvider connectivity service > configuration in database. > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8294/ > ----------------------------------------------------------- > > Review request for cloudstack. > > > Description > ------- > > There are 13 services defined in com.cloud.network.Network.Service , but > db schema has 12 services with connecitivity missing in > `cloud`.`physical_network_service_providers` . This patch will fix this. In > the > cloudstack api response, we'll see Connectivity service is enabled in > NiciraNvp network service provider servicelist like this: > > { > "listnetworkserviceprovidersresponse": { > "count": 1, > "networkserviceprovider": [ > { > "physicalnetworkid": "80bf64a1-c5ca-4eb1-810e-76917a317d59", > "servicelist": [ > "Connectivity" > ], > "name": "NiciraNvp", > "destinationphysicalnetworkid": "0", > "state": "Disabled", > "id": "efb45f75-9fd7-43aa-9937-b5c871971c00" > } > ] > } > } > > > Diffs > ----- > > api/src/com/cloud/network/PhysicalNetworkServiceProvider.java 1b91311 > packaging/centos63/package.sh 83c0e5e > > server/src/com/cloud/network/dao/PhysicalNetworkServiceProviderVO.jav > a 12b08af > server/src/com/cloud/upgrade/dao/Upgrade40to41.java 5067f39 > setup/db/create-schema.sql fff084e > setup/db/db/schema-40to41.sql PRE-CREATION > > Diff: https://reviews.apache.org/r/8294/diff/ > > > Testing > ------- > > > Thanks, > > Hiroaki Kawai
