----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8905/#review15916 -----------------------------------------------------------
Ship it! Patch failed to apply, I manually fixed some issues; applied on master, pl. check this patch, fixes regressions due to network refactoring merge, networkMgr it networkModel now: commit d7ad2da7e0ea63734c93e21d92f4936a1f909309 Author: Rohit Yadav <[email protected]> Date: Wed Jan 30 17:32:44 2013 -0800 server: Fix network refactor regressions for CLOUDSTACK-297 Signed-off-by: Rohit Yadav <[email protected]> Thanks, your patch applied on master: commit b21595c10dfd64bf2030134eecfcfb2721b69bb4 Author: Harikrishna Patnala <[email protected]> Date: Wed Jan 30 17:09:04 2013 -0800 CLOUDSTACK-297: Reset SSH key to access VM This feature provides resetting a SSH key for an existing VM which means, setting the old ssh key that is assigned to the VM previously with the new ssh key. Signed-off-by: Harikrishna Patnala <[email protected]> Signed-off-by: Rohit Yadav <[email protected]> - Rohit Yadav On Jan. 17, 2013, 1:52 p.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8905/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2013, 1:52 p.m.) > > > Review request for cloudstack and Abhinandan Prateek. > > > Description > ------- > > A user VM can be associated with a SSH key pair while deploying that VM. A > user can SSH into the VM using the SSH private Key. > using this feature we can reset that SSH key pair corresponding to that VM, > i.e., to associate a new SSH key pair to the VM. > > > This addresses bug CLOUDSTACK-297. > > > Diffs > ----- > > api/src/com/cloud/event/EventTypes.java 87eddca > api/src/com/cloud/network/element/UserDataServiceProvider.java 321ccc7 > api/src/com/cloud/vm/UserVmService.java b1ebe10 > api/src/org/apache/cloudstack/api/command/user/vm/ResetVMSSHKeyCmd.java > PRE-CREATION > client/tomcatconf/commands.properties.in 182cbd8 > server/src/com/cloud/network/NetworkManager.java 0ca28f8 > server/src/com/cloud/network/NetworkManagerImpl.java 0a1fcd7 > server/src/com/cloud/network/element/CloudZonesNetworkElement.java ae8be0d > server/src/com/cloud/network/element/VirtualRouterElement.java 02a239e > server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java > 2980871 > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > 717da05 > server/src/com/cloud/vm/UserVmManagerImpl.java a6fbdb1 > server/test/com/cloud/network/MockNetworkManagerImpl.java 28d1a60 > server/test/com/cloud/vm/MockUserVmManagerImpl.java 27508b1 > server/test/com/cloud/vpc/MockNetworkManagerImpl.java 642ea10 > > Diff: https://reviews.apache.org/r/8905/diff/ > > > Testing > ------- > > I did the manual testing > - Reset SSH keys for VM already having SSH key > - Reset SSH keys for VM created from password enabled template and already > having SSH key > - Reset SSH keys for VM having no SSH key > - Reset SSH keys for VM created from password enabled template and have no > previous SSH key > - Reset SSH keys for VM already having SSH key when VM is in running state > - Reset SSH keys for VM created from password enabled template and already > having SSH key and VM is in running state > > > Thanks, > > Harikrishna Patnala > >
