----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8466/#review15958 -----------------------------------------------------------
Ship it! Code fixes are good. Per discussion, awsapi needs a unit testing framework to mock servlet container/mock servlet setup due to its design, that Likitha will look into separately. This should be possible with Spring introduction. - Prachi Damle On Dec. 12, 2012, 10:25 a.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8466/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2012, 10:25 a.m.) > > > Review request for cloudstack and Prachi Damle. > > > Description > ------- > > In AWSAPI while parsing the EC2 Query API request for > RevokeSecurityGroupIngress, > 1. look for the right parameter values as per the AWS documentation. > 2. provide support for multiple rules to be revoked simultaneously. > > > This addresses bug CLOUDSTACK-607. > > > Diffs > ----- > > awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 4f74873 > > Diff: https://reviews.apache.org/r/8466/diff/ > > > Testing > ------- > > After setting up AWSAPI, using the boto client called > revoke_security_group(group_name=<sg_name>, ip_protocol=<protocol>, > from_port=<from_port>, to_port=<to_port>, cidr_ip=<cidr>) > Successfully revoked the specified rule belonging to the security-group. > > > Thanks, > > Likitha Shetty > >
