[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568187#comment-13568187
 ] 

Rohit Yadav commented on CLOUDSTACK-1100:
-----------------------------------------

The commit which introduces the change was recently reverted:

commit 1b922e816cdfd4ae5ea19a1c6efdcf0b2400e5a1
Author:     Prasanna Santhanam <[email protected]>
AuthorDate: Thu Jan 31 18:05:56 2013 +0530
Commit:     Prasanna Santhanam <[email protected]>
CommitDate: Thu Jan 31 18:15:41 2013 +0530

    Revert "CS-15922 : to avoid race condition when expunge vm, expunge 
interval and expunge deplay should be larger than 600 second"

    Reverted as per discussion at http://s.apache.org/NOm

    This reverts commit 5060f98268090be1c5fdde14055480c5d18a8a6b.
    Signed-off-by: Prasanna Santhanam <[email protected]>

We should fix the issue and we need to fix the vm lifecycle integration test 
(javelin).
                
> Expunge thread is not kicked off based on global configuration if the global 
> setting is less than 60 seconds
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-1100
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1100
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>    Affects Versions: 4.1.0
>            Reporter: Min Chen
>            Assignee: Anthony Xu
>             Fix For: 4.1.0
>
>
> In our code, we didn't exactly follow the configured
> expunge values (see related bug http://bugs.cloudstack.org/browse/CS-15922)
> String time = configs.get("expunge.interval");
>         _expungeInterval = NumbersUtil.parseInt(time, 86400);
>         if (_expungeInterval < 600) {
>             _expungeInterval = 600;
>         }
>         time = configs.get("expunge.delay");
>         _expungeDelay = NumbersUtil.parseInt(time, _expungeInterval);
>         if (_expungeDelay < 600) {
>             _expungeDelay = 600;
>         }
> So even though that we have 60 seconds in our global config, our code
> hard-coded that to at least 10 mins to start expunge thread.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to