----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9179/#review16000 -----------------------------------------------------------
Ship it! commit to master 13ee8d18653da5c1a08e5762059452b387f32b61 - Murali Reddy On Feb. 1, 2013, 9:22 a.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9179/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2013, 9:22 a.m.) > > > Review request for cloudstack, Murali Reddy and Chiradeep Vittal. > > > Description > ------- > > Review request for Persistent networks > ====================================== > > a) A flag called 'Persistent' added to the network offerings will define if > the network created using the network offering is persistent or not. Default > value is false. > > b) After network creation, in the following 3 cases network will be > implemented (persistent is true) > 1. Creation of Guest network > 2. Moving VM to another user > 3. Associating IP Address to an account > > c) Network GC will not shutdown the network if it is persistent > > > This addresses bug CLOUDSTACK-706. > > > Diffs > ----- > > api/src/com/cloud/offering/NetworkOffering.java f2c4de5 > api/src/org/apache/cloudstack/api/ApiConstants.java f704aec > > api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java > 9d3ceb8 > api/src/org/apache/cloudstack/api/response/NetworkOfferingResponse.java > 5c14791 > api/src/org/apache/cloudstack/api/response/NetworkResponse.java ba8ea32 > server/src/com/cloud/api/ApiResponseHelper.java 0ae4f0f > server/src/com/cloud/configuration/ConfigurationManager.java 09e8ac9 > server/src/com/cloud/configuration/ConfigurationManagerImpl.java c8acf3b > server/src/com/cloud/network/NetworkManagerImpl.java 218583b > server/src/com/cloud/network/NetworkServiceImpl.java 622b448 > server/src/com/cloud/network/dao/NetworkDaoImpl.java 2c5b46d > server/src/com/cloud/network/dao/NetworkOpDaoImpl.java 298156e > server/src/com/cloud/offerings/NetworkOfferingVO.java efaca76 > server/src/com/cloud/server/ConfigurationServerImpl.java 7d12412 > server/src/com/cloud/vm/UserVmManagerImpl.java a53e132 > server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 17ad2e1 > server/test/com/cloud/vpc/MockNetworkManagerImpl.java 5d9c436 > server/test/com/cloud/vpc/dao/MockNetworkOfferingDaoImpl.java 496864b > setup/db/create-schema.sql beb9103 > setup/db/db/schema-40to410.sql 39b686e > > Diff: https://reviews.apache.org/r/9179/diff/ > > > Testing > ------- > > Manual testing done > 1. Create network offering with persistent set to true for Isolated network - > creates an offering > 2. Create network offering with persistent set to true for Shared network - > fails > 3. Create guest network with persistent network offering - Network should get > implemented and should have a VLAN id > 4. Create guest network with a non persistent network offering - Network > should remain in allocated state > 5. Delete the last running VM of a persistent network - after a wait of > network.gc.interval the network should remain in implemented state > 6. Upgrade network offering of a non-persistent network to a persistent > network - network should get implemented > 7. Upgrade network offering of a persistent network to a non persistent > network - if there are no running VM's network should get shutdown during > network gc > 8. Move a VM from a user account to another user account that has no network > - a network created for the VM should be persistent if the available network > offering is persistent (same for associate ip address) > (repeat all of above for VPC network) > > > Thanks, > > Likitha Shetty > >
