----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9228/#review16439 -----------------------------------------------------------
Ship it! Thanks for fixing this logging that was misleading. Commit hash: 1e8648c92de9df281aaabc5067d6d1d61be3a4a3 - Prachi Damle On Feb. 1, 2013, 6:03 a.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9228/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2013, 6:03 a.m.) > > > Review request for cloudstack and Prachi Damle. > > > Description > ------- > > This is observed in the awsapi.log for all Describe* EC2 commands when the > response object returned by CS has no elements. But with EC2DescribeImages > command it is always observed. This is because every time DescribeImage is > fired, we call CS listTemplates command multiple times, each time setting a > different value for the templateFilter parameter (e.g. featured, executable, > community etc.). And for some of these CS calls made we obtain am empty > response and hence the message in the logs. > > > This addresses bug CLOUDSTACK-1124. > > > Diffs > ----- > > awsapi/src/com/cloud/stack/CloudStackClient.java 5002aa5 > > Diff: https://reviews.apache.org/r/9228/diff/ > > > Testing > ------- > > Using boto, call get_all_images - awsapi.log should not contain 'Unable to > find responseObjName:[template]. Returning null! Exception: Property > listtemplatesresponse.template is resolved to null JSON element on object: > {"listtemplatesresponse":{}} ' > > > Thanks, > > Likitha Shetty > >
