----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9158/#review16635 -----------------------------------------------------------
server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/9158/#comment35305> What if template is null? The null check that's happening in the 'else' case should be made for both existing as well as new template - Koushik Das On Feb. 7, 2013, 11:32 a.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9158/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2013, 11:32 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Koushik Das. > > > Description > ------- > > CLOUDSTACK-667: VM's base image updation facility > disconnect the root disk >> destroy root disk >> create a new disk from new > template >> attach new disk as root disk to the vm > > > This addresses bug CLOUDSTACK-667. > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java e98c2f2 > server/src/com/cloud/vm/UserVmManagerImpl.java 390a2a2 > server/test/com/cloud/vm/UserVmManagerTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/9158/diff/ > > > Testing > ------- > > Did the manual testing locally > > > Thanks, > > Harikrishna Patnala > >
