There is only issue I see with expanding tabs, and fixing trailing whitespaces => merge conflicts! (yes we can always ignore space changes but...) Should we do it?
Regards. On Thu, Feb 21, 2013 at 2:58 PM, Mice Xia <[email protected]> wrote: > +1 to git hook (for future) and sed (for existing) > > -Mice > > -----Original Message----- > From: [email protected] [mailto:[email protected]] On Behalf Of > Rohit Yadav > Sent: Thursday, February 21, 2013 4:37 PM > To: [email protected] > Subject: Re: Commits with tabs & trailing white space > > On Thu, Feb 21, 2013 at 11:11 AM, Mice Xia <[email protected]> > wrote: >> Sateesh, >> >> I just run some scripts: >> >> find . -name *.java |wc -l >> 4220 >> >> find . -name *.java | xargs egrep -c "^[[:space:]]+$" | grep -v 0 | >> wc -l >> 2117 > > Mice you want to run a sed cmd to fix all the java files? Just say it, I'll > do it. > Without ranting again about it, let me point to an old solution I use and > suggest folks to follow: > http://markmail.org/message/huy7ps5gncpf6asz > > Regards. > >> >> So we have half java source files that have leading spaces in an empty line, >> not to mention trailing spaces and tabs. >> >> If we are going to enforce this rule as a convention, instead of notifying >> each commit that breaks this convention, I would suggest we automate this >> correction. >> >> Regards >> Mice >> >> -----Original Message----- >> From: Devdeep Singh [mailto:[email protected]] >> Sent: Thursday, February 21, 2013 1:14 PM >> To: [email protected] >> Subject: RE: Commits with tabs & trailing white space >> >> As a contributor if a patch is submitted, applying that patch will fail if >> it has trailing whitespaces. Maybe we should honor the convention of not >> submitting code/patches with trailing spaces too. >> >> Regards, >> Devdeep >> >>> -----Original Message----- >>> From: Mice Xia [mailto:[email protected]] >>> Sent: Thursday, February 21, 2013 10:29 AM >>> To: [email protected] >>> Subject: RE: Commits with tabs & trailing white space >>> >>> Leading spaces can be found everywhere in the codes, I think that's >>> caused by IDE when intentionally leave an empty line. To me it's not >>> a big deal and reviewboard provides "Hide Extra Whitespace & Hide >>> Whitespace changes" >>> to filter these. Tab should be avoided, we use 4 spaces indent by >>> code convention. >>> >>> -Mice >>> >>> -----Original Message----- >>> From: David Nalley [mailto:[email protected]] >>> Sent: Thursday, February 21, 2013 12:44 PM >>> To: [email protected] >>> Subject: Re: Commits with tabs & trailing white space >>> >>> On Wed, Feb 20, 2013 at 11:37 PM, Sateesh Chodapuneedi >>> <[email protected]> wrote: >>> > Seeing commits containing tab spaces and trailing white spaces. >>> > Aren't we enforcing these checks? >>> > >>> > Regards, >>> > Sateesh >>> > >>> >>> We desperately need more folks looking at the commit mails and >>> calling these issues out. (It looks like you are doing the first, how >>> about sending the nudge when you see it) Replies to commit messages >>> will by default hit cloudstack- dev. >>> >>> --David
