> On March 4, 2013, 7:53 p.m., Hugo Trippaers wrote: > > Ship It! > > Hugo Trippaers wrote: > commit in master: ff099fa651e8476220332d7e1cc4b24746802cfe > > Dave, can you update the documentation in docs for the bits you changed?
Sure - I've left CLOUDSTACK-1311 open for now; I'll make the doc changes and submit a separate review. - Dave ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9604/#review17353 ----------------------------------------------------------- On March 1, 2013, 7:46 a.m., Dave Cahill wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9604/ > ----------------------------------------------------------- > > (Updated March 1, 2013, 7:46 a.m.) > > > Review request for cloudstack, Hugo Trippaers, Wido den Hollander, and Marcus > Sorensen. > > > Description > ------- > > Feature spec: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Allow+specification+of+different+VIF+drivers+per+traffic+type+in+KVM > > Jira ticket: > https://issues.apache.org/jira/browse/CLOUDSTACK-1311 > > Adds the ability to specify different VIF drivers per traffic type in KVM. > > > This addresses bug CLOUDSTACK-1311. > > > Diffs > ----- > > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > 99b8723 > > plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVifDriverTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/9604/diff/ > > > Testing > ------- > > Added unit tests to test all variations of this new configuration (no > configuration, defaults, override some traffic etc). > > Built and deployed, spun up Advanced Isolated network with two VMs, verified > internal and external connectivity. > > > Thanks, > > Dave Cahill > >
