On Tue, Mar 5, 2013 at 1:42 PM, Alex Huang <alex.hu...@citrix.com> wrote: > Hi All, > > As most of you are aware, the master branch keeps getting broken by checkins > for various reasons. Committers need to be more responsible about their > checkins but I don't think we can depend on that happening. There are > various reasons. The most obvious to me is that granting committership is > not based on code competency. (And I don't think it should.) Given that we > need to build a BVT system for ensure that checkins do not break the branch. >
I like the idea of this alot. It's not quite continuous integration, but its closer than where we are now. A couple of additional comments. This really isn't about code competency. There are really three problems. The first is that people are fallible, make mistakes, regardless of their competency. The second is that CloudStack is a rather large codebase, with a ton of different codepaths, many that are currently very difficult to exercise from a developers laptop. Third, CloudStack has lots of moving pieces, many that you may no know about. I am ok with gating feature merges on running BVT tests or more. I do not think that this is a replacement for unit tests, it's just another, more intensive, layer of testing. Tell me how I can help with this. --David
