----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9871/ -----------------------------------------------------------
(Updated March 15, 2013, 6:51 a.m.) Review request for cloudstack, Hugo Trippaers and Chiradeep Vittal. Changes ------- add Chiradeep and Hugo as reviewers Description ------- The location of the virtual machine is provided by DeployDestination, which will be passed in NetworkGuru#reserve and NetworkElement#prepare. During the virtual machine migration, it actually changes DeployDestination and it looks like that it will tell that event to network components as it has NetworkManager#prepareNicForMigration. The problem is that althogh the interface has that method, NetworkManagerImpl does not tell the DeployDestination changes to network components. So IMHO, we need to add calls of NetworkGuru#reserve and NetworkElement#prepare in NetworkManagerImpl#prepareNicForMigration . And then, we also need to add calls NetworkGuru#release and NetworkElement#release after the migration, otherwise the network resources that plugin reserved will be kept even when the vm leaves off. Created a first minimum patch to show the concept. This addresses bug CLOUDSTACK-1638. Diffs ----- server/src/com/cloud/network/NetworkManager.java 8b6bf9a server/src/com/cloud/network/NetworkManagerImpl.java ba5ab5d server/src/com/cloud/vm/VirtualMachineManagerImpl.java 0aeef0e Diff: https://reviews.apache.org/r/9871/diff/ Testing ------- Thanks, Hiroaki Kawai
